Changeset 146092 in webkit

Timestamp:

Mar 18, 2013 11:33:34 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
​https://bugs.webkit.org/show_bug.cgi?id=111733

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Fix missing brace.

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebKitSupport/SelectionHandler.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-03-18  Alberto Garcia  <agarcia@igalia.com>
+
+        [BlackBerry] Prevent text selection inside Colour and Date/Time input fields
+        https://bugs.webkit.org/show_bug.cgi?id=111733
+
+        Reviewed by Rob Buis.
+
+        Fix missing brace.
+
+        * WebKitSupport/SelectionHandler.cpp:
+        (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
+
 2013-03-18  Alberto Garcia  <agarcia@igalia.com>
 

trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp

@@ -1161 +1161 @@
         return;
 
-    if (Node* focusedNode = frame->document()->focusedNode()
-        && (focusedNode->hasTagName(HTMLNames::selectTag) || (focusedNode->isElementNode() && DOMSupport::isPopupInputField(toElement(focusedNode))))) {
+    if (Node* focusedNode = frame->document()->focusedNode()) {
+        if (focusedNode->hasTagName(HTMLNames::selectTag) || (focusedNode->isElementNode() && DOMSupport::isPopupInputField(toElement(focusedNode)))) {
             SelectionLog(Platform::LogLevelInfo, "SelectionHandler::selectionPositionChanged selection is on a popup control, skipping rendering.");
             return;