Changeset 146117 in webkit

Timestamp:

Mar 18, 2013 1:56:06 PM (11 years ago)

Author:

hans@chromium.org

Message:

Fix GridTrackSize::operator==
​https://bugs.webkit.org/show_bug.cgi?id=112501

Reviewed by Eric Seidel.

Source/WebCore:

There was a missing "other." in the function.

This was found by experimenting with a potential new Clang warning.

Test: fast/css-grid-layout/grid-dynamic-updates-relayout.html

• rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::operator==):

LayoutTests:

Add a test to check that style changes cause relayout correctly.

• fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt: Added.
• fast/css-grid-layout/grid-dynamic-updates-relayout.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt (added)
• LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/GridTrackSize.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-18  Hans Wennborg  <hans@chromium.org>
+
+        Fix GridTrackSize::operator==
+        https://bugs.webkit.org/show_bug.cgi?id=112501
+
+        Reviewed by Eric Seidel.
+
+        Add a test to check that style changes cause relayout correctly.
+
+        * fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt: Added.
+        * fast/css-grid-layout/grid-dynamic-updates-relayout.html: Added.
+
 2013-03-15  Jeffrey Pfau  <jpfau@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-18  Hans Wennborg  <hans@chromium.org>
+
+        Fix GridTrackSize::operator==
+        https://bugs.webkit.org/show_bug.cgi?id=112501
+
+        Reviewed by Eric Seidel.
+
+        There was a missing "other." in the function.
+
+        This was found by experimenting with a potential new Clang warning.
+
+        Test: fast/css-grid-layout/grid-dynamic-updates-relayout.html
+
+        * rendering/style/GridTrackSize.h:
+        (WebCore::GridTrackSize::operator==):
+
 2013-03-18  Alec Flett  <alecflett@chromium.org>
 

trunk/Source/WebCore/rendering/style/GridTrackSize.h

@@ -96 +96 @@
     bool operator==(const GridTrackSize& other) const
     {
-        return m_type == other.m_type && m_minTrackBreadth == other.m_minTrackBreadth && m_maxTrackBreadth == m_maxTrackBreadth;
+        return m_type == other.m_type && m_minTrackBreadth == other.m_minTrackBreadth && m_maxTrackBreadth == other.m_maxTrackBreadth;
     }