Changeset 146829 in webkit

Timestamp:

Mar 25, 2013 5:14:45 PM (11 years ago)

Author:

mhahnenberg@apple.com

Message:

JSObject::enterDictionaryIndexingMode doesn't have a case for ALL_BLANK_INDEXING_TYPES
​https://bugs.webkit.org/show_bug.cgi?id=113236

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• runtime/JSObject.cpp:

(JSC::JSObject::enterDictionaryIndexingMode): We forgot blank indexing types.

LayoutTests:

New test case that tests calling Object.freeze on Array.prototype.

• fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Added.
• fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Added.
• fast/js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt (added)
• LayoutTests/fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type.html (added)
• LayoutTests/fast/js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/JSObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-25  Mark Hahnenberg  <mhahnenberg@apple.com>
+
+        JSObject::enterDictionaryIndexingMode doesn't have a case for ALL_BLANK_INDEXING_TYPES
+        https://bugs.webkit.org/show_bug.cgi?id=113236
+
+        Reviewed by Geoffrey Garen.
+
+        New test case that tests calling Object.freeze on Array.prototype.
+
+        * fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Added.
+        * fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Added.
+        * fast/js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Added.
+
 2013-03-25  James Robinson  <jamesr@chromium.org>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-03-25  Mark Hahnenberg  <mhahnenberg@apple.com>
+
+        JSObject::enterDictionaryIndexingMode doesn't have a case for ALL_BLANK_INDEXING_TYPES
+        https://bugs.webkit.org/show_bug.cgi?id=113236
+
+        Reviewed by Geoffrey Garen.
+
+        * runtime/JSObject.cpp:
+        (JSC::JSObject::enterDictionaryIndexingMode): We forgot blank indexing types.
+
 2013-03-23  Mark Hahnenberg  <mhahnenberg@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSObject.cpp

@@ -573 +573 @@
 {
     switch (structure()->indexingType()) {
+    case ALL_BLANK_INDEXING_TYPES:
     case ALL_UNDECIDED_INDEXING_TYPES:
     case ALL_INT32_INDEXING_TYPES: