Changeset 146878 in webkit

Timestamp:

Mar 26, 2013 6:51:24 AM (11 years ago)

Author:

allan.jensen@digia.com

Message:

[Qt] Poor rounding in GraphicsContext::drawLineForText
​https://bugs.webkit.org/show_bug.cgi?id=113301

Reviewed by Jocelyn Turcotte.

Round the position of the line decoration, so lines on subpixel
coordinates are not always rounded up.

• platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLineForText):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/GraphicsContextQt.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-26  Allan Sandfeld Jensen  <allan.jensen@digia.com>
+
+        [Qt] Poor rounding in GraphicsContext::drawLineForText
+        https://bugs.webkit.org/show_bug.cgi?id=113301
+
+        Reviewed by Jocelyn Turcotte.
+
+        Round the position of the line decoration, so lines on subpixel
+        coordinates are not always rounded up.
+
+        * platform/graphics/qt/GraphicsContextQt.cpp:
+        (WebCore::GraphicsContext::drawLineForText):
+
 2013-03-26  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

@@ -1034 +1034 @@
 #endif // defined(Q_WS_X11)
 
-    // FIXME: Loss of precision here. Might consider rounding.
-    drawLine(IntPoint(startPoint.x(), startPoint.y()), IntPoint(endPoint.x(), endPoint.y()));
+    drawLine(roundedIntPoint(startPoint), roundedIntPoint(endPoint));
 }