Changeset 146882 in webkit
- Timestamp:
- Mar 26, 2013 8:06:59 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r146881 r146882 1 2013-03-26 Hajime Morrita <morrita@google.com> 2 3 remoeveAllEventListeners() should be called to shadow trees 4 https://bugs.webkit.org/show_bug.cgi?id=113037 5 6 Reviewed by Dimitri Glazkov. 7 8 * fast/dom/shadow/resources/shadow-tree-listener-clearance-frame.html: Added. 9 * fast/dom/shadow/shadow-tree-listener-clearance-expected.txt: Added. 10 * fast/dom/shadow/shadow-tree-listener-clearance.html: Added. 11 1 12 2013-03-26 Yury Semikhatsky <yurys@chromium.org> 2 13 -
trunk/Source/WebCore/ChangeLog
r146879 r146882 1 2013-03-26 Hajime Morrita <morrita@google.com> 2 3 remoeveAllEventListeners() should be called to shadow trees 4 https://bugs.webkit.org/show_bug.cgi?id=113037 5 6 Reviewed by Dimitri Glazkov. 7 8 Document::removeAllEventListeners() doesn't traverse shadow tree, but we should. 9 This change override Element::removeAllEventListeners() so that it cleans its shadow trees up. 10 11 Test: fast/dom/shadow/shadow-tree-listener-clearance.html 12 13 * dom/Element.cpp: 14 (WebCore::Element::removeAllEventListeners): 15 (WebCore): 16 * dom/Element.h: 17 (Element): 18 * dom/ElementShadow.cpp: 19 (WebCore::ElementShadow::removeAllEventListeners): Added. 20 (WebCore): 21 * dom/ElementShadow.h: 22 (ElementShadow): 23 1 24 2013-03-26 Andrei Bucur <abucur@adobe.com> 2 25 -
trunk/Source/WebCore/dom/Element.cpp
r146860 r146882 1694 1694 } 1695 1695 1696 void Element::removeAllEventListeners() 1697 { 1698 ContainerNode::removeAllEventListeners(); 1699 if (ElementShadow* shadow = this->shadow()) 1700 shadow->removeAllEventListeners(); 1701 } 1702 1696 1703 void Element::beginParsingChildren() 1697 1704 { -
trunk/Source/WebCore/dom/Element.h
r146860 r146882 628 628 virtual void removedFrom(ContainerNode*) OVERRIDE; 629 629 virtual void childrenChanged(bool changedByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0); 630 virtual void removeAllEventListeners() OVERRIDE; 630 631 631 632 virtual bool willRecalcStyle(StyleChange); -
trunk/Source/WebCore/dom/ElementShadow.cpp
r141570 r146882 124 124 } 125 125 126 void ElementShadow::removeAllEventListeners() 127 { 128 for (ShadowRoot* root = youngestShadowRoot(); root; root = root->olderShadowRoot()) { 129 for (Node* node = root; node; node = NodeTraversal::next(node)) 130 node->removeAllEventListeners(); 131 } 132 } 133 126 134 void ElementShadow::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const 127 135 { -
trunk/Source/WebCore/dom/ElementShadow.h
r141218 r146882 65 65 bool needsStyleRecalc() const; 66 66 void recalcStyle(Node::StyleChange); 67 void removeAllEventListeners(); 67 68 68 69 void invalidateDistribution() { m_distributor.invalidateDistribution(host()); }
Note: See TracChangeset
for help on using the changeset viewer.