Changeset 146896 in webkit


Ignore:
Timestamp:
Mar 26, 2013 9:14:59 AM (11 years ago)
Author:
morrita@google.com
Message:

https://bugs.webkit.org/show_bug.cgi?id=113164
Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML

Source/WebCore:

These APIs also create new elements thus should have V8DeliverCustomElementCallbacks attribute.

Reviewed by Dimitri Glazkov.

Test: Updated lifecycle-ready-creation-api.html.

  • html/HTMLElement.idl:

LayoutTests:

Reviewed by Dimitri Glazkov.

  • fast/dom/custom/lifecycle-ready-creation-api-expected.txt:
  • fast/dom/custom/lifecycle-ready-creation-api.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r146895 r146896  
     12013-03-26  Hajime Morrita  <morrita@google.com>
     2
     3        https://bugs.webkit.org/show_bug.cgi?id=113164
     4        Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        * fast/dom/custom/lifecycle-ready-creation-api-expected.txt:
     9        * fast/dom/custom/lifecycle-ready-creation-api.html:
     10
    1112013-03-26  Jochen Eisinger  <jochen@chromium.org>
    212
  • trunk/LayoutTests/fast/dom/custom/lifecycle-ready-creation-api-expected.txt

    r146583 r146896  
    2020PASS importedBar.firstChild.callbacksCalled is true
    2121PASS window.callbacksCalled is ['DIV', 'X-FOO']
     22PASS window.callbacksCalled is ['X-FOO']
     23PASS window.callbacksCalled is ['X-FOO']
    2224PASS successfullyParsed is true
    2325
  • trunk/LayoutTests/fast/dom/custom/lifecycle-ready-creation-api.html

    r146583 r146896  
    5757shouldBe("window.callbacksCalled", "['DIV', 'X-FOO']");
    5858
     59window.callbacksCalled = [];
     60var toBeReplaced = document.createElement("div");
     61document.body.appendChild(toBeReplaced);
     62toBeReplaced.outerHTML = "<x-foo></x-foo>";
     63shouldBe("window.callbacksCalled", "['X-FOO']");
     64
     65window.callbacksCalled = [];
     66var insertionPlaceHolder = document.createElement("div");
     67document.body.appendChild(insertionPlaceHolder);
     68insertionPlaceHolder.insertAdjacentHTML("beforebegin", "<x-foo></x-foo>");
     69shouldBe("window.callbacksCalled", "['X-FOO']");
     70
    5971</script>
    6072<script src="../../js/resources/js-test-post.js"></script>
  • trunk/Source/WebCore/ChangeLog

    r146893 r146896  
     12013-03-26  Hajime Morrita  <morrita@google.com>
     2
     3        https://bugs.webkit.org/show_bug.cgi?id=113164
     4        Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML
     5
     6        These APIs also create new elements thus should have V8DeliverCustomElementCallbacks attribute.
     7
     8        Reviewed by Dimitri Glazkov.
     9
     10        Test: Updated lifecycle-ready-creation-api.html.
     11
     12        * html/HTMLElement.idl:
     13
    1142013-03-26  Ilya Tikhonovsky  <loislo@chromium.org>
    215
  • trunk/Source/WebCore/html/HTMLElement.idl

    r146583 r146896  
    4444             [TreatNullAs=NullString] attribute DOMString innerText
    4545                 setter raises(DOMException);
    46              [TreatNullAs=NullString] attribute DOMString outerHTML
     46             [TreatNullAs=NullString, V8DeliverCustomElementCallbacks] attribute DOMString outerHTML
    4747                 setter raises(DOMException);
    4848             [TreatNullAs=NullString] attribute DOMString outerText
     
    5252                                  in [Optional=DefaultIsUndefined] Element element)
    5353        raises(DOMException);
     54    [V8DeliverCustomElementCallbacks]
    5455    void insertAdjacentHTML(in [Optional=DefaultIsUndefined] DOMString where,
    5556                            in [Optional=DefaultIsUndefined] DOMString html)
Note: See TracChangeset for help on using the changeset viewer.