Changeset 146950 in webkit

Timestamp:

Mar 26, 2013 5:12:31 PM (11 years ago)

Author:

dgrogan@chromium.org

Message:

IndexedDB: Histogram cause of LevelDB write errors
​https://bugs.webkit.org/show_bug.cgi?id=113350

Reviewed by Tony Chang.

Add histogram for source of LevelDB errors on Write in addition to
Open.

No new tests - no good way to test histogram code.

• platform/leveldb/LevelDBDatabase.cpp:

(WebCore::histogramLevelDBError):
(WebCore):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::write):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/leveldb/LevelDBDatabase.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-26  David Grogan  <dgrogan@chromium.org>
+
+        IndexedDB: Histogram cause of LevelDB write errors
+        https://bugs.webkit.org/show_bug.cgi?id=113350
+
+        Reviewed by Tony Chang.
+
+        Add histogram for source of LevelDB errors on Write in addition to
+        Open.
+
+        No new tests - no good way to test histogram code.
+
+        * platform/leveldb/LevelDBDatabase.cpp:
+        (WebCore::histogramLevelDBError):
+        (WebCore):
+        (WebCore::LevelDBDatabase::open):
+        (WebCore::LevelDBDatabase::write):
+
 2013-03-26  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

@@ -160 +160 @@
 }
 
+static void histogramLevelDBError(const char* histogramName, const leveldb::Status& s)
+{
+    ASSERT(!s.ok());
+    enum {
+        LevelDBNotFound,
+        LevelDBCorruption,
+        LevelDBIOError,
+        LevelDBOther,
+        LevelDBMaxError
+    };
+    int levelDBError = LevelDBOther;
+    if (s.IsNotFound())
+        levelDBError = LevelDBNotFound;
+    else if (s.IsCorruption())
+        levelDBError = LevelDBCorruption;
+    else if (s.IsIOError())
+        levelDBError = LevelDBIOError;
+    HistogramSupport::histogramEnumeration(histogramName, levelDBError, LevelDBMaxError);
+}
+
 PassOwnPtr<LevelDBDatabase> LevelDBDatabase::open(const String& fileName, const LevelDBComparator* comparator)
 {
@@ -168 +188 @@
 
     if (!s.ok()) {
-        enum {
-            LevelDBNotFound,
-            LevelDBCorruption,
-            LevelDBIOError,
-            LevelDBOther,
-            LevelDBMaxError
-        };
-        int levelDBError = LevelDBOther;
-        if (s.IsNotFound())
-            levelDBError = LevelDBNotFound;
-        else if (s.IsCorruption())
-            levelDBError = LevelDBCorruption;
-        else if (s.IsIOError())
-            levelDBError = LevelDBIOError;
-        HistogramSupport::histogramEnumeration("WebCore.IndexedDB.LevelDBOpenErrors", levelDBError, LevelDBMaxError);
-
+        histogramLevelDBError("WebCore.IndexedDB.LevelDBOpenErrors", s);
         histogramFreeSpace("Failure", fileName);
 
@@ -277 +282 @@
     if (s.ok())
         return true;
+    histogramLevelDBError("WebCore.IndexedDB.LevelDBWriteErrors", s);
     LOG_ERROR("LevelDB write failed: %s", s.ToString().c_str());
     return false;