Changeset 146987 in webkit

Timestamp:

Mar 27, 2013 8:35:45 AM (11 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: CPU profiler. Swap FlameChart with Data Grid.
​https://bugs.webkit.org/show_bug.cgi?id=113395

Reviewed by Pavel Feldman.

Looks like FlameChart is more powerful and flexible instrument
than plain old ProfileTree in DataGrid. The same action like
'look for the most expensive function in a frame' could be easily
done with FlameChart and need number of clicks in DataGrid.
So in an offline discussion we decided to place FlameChart on top of DataGrid.

• inspector/front-end/CPUProfileView.js:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/CPUProfileView.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-27  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: CPU profiler. Swap FlameChart with Data Grid.
+        https://bugs.webkit.org/show_bug.cgi?id=113395
+
+        Reviewed by Pavel Feldman.
+
+        Looks like FlameChart is more powerful and flexible instrument
+        than plain old ProfileTree in DataGrid. The same action like
+        'look for the most expensive function in a frame' could be easily
+        done with FlameChart and need number of clicks in DataGrid.
+        So in an offline discussion we decided to place FlameChart on top of DataGrid.
+
+        * inspector/front-end/CPUProfileView.js:
+
 2013-03-27  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/inspector/front-end/CPUProfileView.js

@@ -57 +57 @@
         this._splitView.show(this.element);
 
-        this.dataGrid.show(this._splitView.firstElement());
-
         this.flameChart = new WebInspector.FlameChart(this);
         this.flameChart.addEventListener(WebInspector.FlameChart.Events.SelectedNode, this._revealProfilerNode.bind(this));
-        this.flameChart.show(this._splitView.secondElement());
+        this.flameChart.show(this._splitView.firstElement());
+
+        this.dataGrid.show(this._splitView.secondElement());
     } else
         this.dataGrid.show(this.element);