Changeset 147008 in webkit

Timestamp:

Mar 27, 2013 1:51:11 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

Selection code spends a lot of time in InlineTextBox::localSelectionRect
​https://bugs.webkit.org/show_bug.cgi?id=113364

Reviewed by Enrica Casucci.

Avoid computing the font width when we're selecting the entire line box.

This appears to be 25-26% improvement on Interactive/SelectAll:Time.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::localSelectionRect):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/InlineTextBox.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Selection code spends a lot of time in InlineTextBox::localSelectionRect
+        https://bugs.webkit.org/show_bug.cgi?id=113364
+
+        Reviewed by Enrica Casucci.
+
+        Avoid computing the font width when we're selecting the entire line box.
+
+        This appears to be 25-26% improvement on Interactive/SelectAll:Time.
+
+        * rendering/InlineTextBox.cpp:
+        (WebCore::InlineTextBox::localSelectionRect):
+
 2013-03-26  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebCore/rendering/InlineTextBox.cpp

@@ -207 +207 @@
         endPos = textRun.length();
 
-    LayoutRect r = enclosingIntRect(font.selectionRectForText(textRun, FloatPoint(logicalLeft(), selTop), selHeight, sPos, ePos));
+    FloatPoint startingPoint = FloatPoint(logicalLeft(), selTop);
+    LayoutRect r;
+    if (sPos || ePos != static_cast<int>(m_len))
+        r = enclosingIntRect(font.selectionRectForText(textRun, startingPoint, selHeight, sPos, ePos));
+    else // Avoid computing the font width when the entire line box is selected as an optimization.
+        r = enclosingIntRect(FloatRect(startingPoint, FloatSize(m_logicalWidth, selHeight)));
 
     LayoutUnit logicalWidth = r.width();