Changeset 147028 in webkit


Ignore:
Timestamp:
Mar 27, 2013 5:11:41 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
https://bugs.webkit.org/show_bug.cgi?id=113142

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

Source/WebCore:

Changed CSS grammar to be equivalent to pre-r146588.
CSS error reporting disabled to prevent message overflow.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::isLoggingErrors):

LayoutTests:

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r147022 r147028  
     12013-03-27  Sergey Ryazanov  <serya@chromium.org>
     2
     3        REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
     4        https://bugs.webkit.org/show_bug.cgi?id=113142
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * TestExpectations:
     9        * fast/css/parsing-error-recovery.html:
     10
    1112013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
    212
  • trunk/LayoutTests/TestExpectations

    r145053 r147028  
    88# pending implementation completion and feature enabling
    99webkit.org/b/109570 media/track/regions-webvtt [ Skip ]
     10
     11# pending CSS grammar refactoring
     12webkit.org/b/113401 inspector/console/console-css-warnings.html [ Skip ]
  • trunk/LayoutTests/fast/css/parsing-error-recovery.html

    r120683 r147028  
    4242        }
    4343
     44        .malformed3 {
     45            ;*display:expression(function(){})
     46        }
     47        #test5 {
     48            display:none;
     49        }
     50
    4451        /* Successfully parsed */
    4552        #last {
     
    5360  <div class="to_be_hidden" id="test3">FAIL: Test 3</div>
    5461  <div class="to_be_hidden" id="test4">FAIL: Test 4</div>
     62  <div class="to_be_hidden" id="test5">FAIL: Test 5</div>
    5563  <div class="to_be_shown" id="last">PASS</div>
    5664</body>
  • trunk/Source/WebCore/ChangeLog

    r147027 r147028  
     12013-03-27  Sergey Ryazanov  <serya@chromium.org>
     2
     3        REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
     4        https://bugs.webkit.org/show_bug.cgi?id=113142
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Changed CSS grammar to be equivalent to pre-r146588.
     9        CSS error reporting disabled to prevent message overflow.
     10
     11        * css/CSSGrammar.y.in:
     12        * css/CSSParser.cpp:
     13        (WebCore::CSSParser::isLoggingErrors):
     14
    1152013-03-27  Andrey Lushnikov  <lushnikov@chromium.org>
    216
  • trunk/Source/WebCore/css/CSSGrammar.y.in

    r146781 r147028  
    20342034
    20352035errors:
    2036     error {
    2037         $$ = parser->currentLocation();
    2038     }
    2039   | errors error {
    2040         $$ = $1;
     2036    error error_location {
     2037        $$ = $2;
    20412038    }
    20422039    ;
  • trunk/Source/WebCore/css/CSSParser.cpp

    r146781 r147028  
    1129911299bool CSSParser::isLoggingErrors()
    1130011300{
    11301     return m_logErrors;
     11301    // FIXME: return logging back (https://bugs.webkit.org/show_bug.cgi?id=113401).
     11302    return false;
    1130211303}
    1130311304
Note: See TracChangeset for help on using the changeset viewer.