Changeset 147037 in webkit

Timestamp:

Mar 27, 2013 5:39:23 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

cache parsed interfaces in CodeGenerator.pm
​https://bugs.webkit.org/show_bug.cgi?id=113446

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-27
Reviewed by Kentaro Hara.

When generating binding for an interface, informations about parent
interfaces are sometimes needed several times. This patch caches
those the parsed interface. When generating all WebCore bindings, this
results in a speedup of about 40% for JavaScriptCore and about 80% for
V8.

No new tests: no change in behaviour.

• bindings/scripts/CodeGenerator.pm:

(ParseInterface):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGenerator.pm (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-27  Arnaud Renevier  <a.renevier@sisa.samsung.com>
+
+        cache parsed interfaces in CodeGenerator.pm
+        https://bugs.webkit.org/show_bug.cgi?id=113446
+
+        Reviewed by Kentaro Hara.
+
+        When generating binding for an interface, informations about parent
+        interfaces are sometimes needed several times. This patch caches
+        those the parsed interface. When generating all WebCore bindings, this
+        results in a speedup of about 40% for JavaScriptCore and about 80% for
+        V8.
+
+        No new tests: no change in behaviour.
+
+        * bindings/scripts/CodeGenerator.pm:
+        (ParseInterface):
+
 2013-03-27  KyungTae Kim <ktf.kim@samsung.com> and Yongjun Zhang  <yongjun_zhang@apple.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm

@@ -96 +96 @@
 # Cache of IDL file pathnames.
 my $idlFiles;
+my $cachedInterfaces = {};
 
 # Default constructor
@@ -294 +295 @@
     return undef if $interfaceName eq 'Object';
 
+    if (exists $cachedInterfaces->{$interfaceName}) {
+        return $cachedInterfaces->{$interfaceName};
+    }
+
     # Step #1: Find the IDL file associated with 'interface'
     my $filename = $object->IDLFileForInterface($interfaceName)
@@ -305 +310 @@
 
     foreach my $interface (@{$document->interfaces}) {
-        return $interface if $interface->name eq $interfaceName;
+        if ($interface->name eq $interfaceName) {
+            $cachedInterfaces->{$interfaceName} = $interface;
+            return $interface;
+        }
     }