Changeset 147120 in webkit

Timestamp:

Mar 28, 2013 8:48:28 AM (11 years ago)

Author:

wangxianzhu@chromium.org

Message:

Non-painting fixed elements should not cause repaints on scroll
​https://bugs.webkit.org/show_bug.cgi?id=110430

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/scroll-fixed-layer-no-content.html
Test: compositing/repaint/scroll-fixed-layer-out-of-view.html

• page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath): Check for no-content and out-of-view flag set by RLC.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Moved the check for no-content above out-of-view because it's faster.

LayoutTests:

• compositing/repaint/scroll-fixed-layer-no-content.html: Added.
• compositing/repaint/scroll-fixed-layer-no-content-expected.txt: Added.
• compositing/repaint/scroll-fixed-layer-out-of-view.html: Added.
• compositing/repaint/scroll-fixed-layer-out-of-view-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/repaint/scroll-fixed-layer-no-content-expected.txt (added)
• LayoutTests/compositing/repaint/scroll-fixed-layer-no-content.html (added)
• LayoutTests/compositing/repaint/scroll-fixed-layer-out-of-view-expected.txt (added)
• LayoutTests/compositing/repaint/scroll-fixed-layer-out-of-view.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/FrameView.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerCompositor.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-28  Xianzhu Wang  <wangxianzhu@chromium.org>
+
+        Non-painting fixed elements should not cause repaints on scroll
+        https://bugs.webkit.org/show_bug.cgi?id=110430
+
+        Reviewed by Simon Fraser.
+
+        * compositing/repaint/scroll-fixed-layer-no-content.html: Added.
+        * compositing/repaint/scroll-fixed-layer-no-content-expected.txt: Added.
+        * compositing/repaint/scroll-fixed-layer-out-of-view.html: Added.
+        * compositing/repaint/scroll-fixed-layer-out-of-view-expected.txt: Added.
+
 2013-03-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-28  Xianzhu Wang  <wangxianzhu@chromium.org>
+
+        Non-painting fixed elements should not cause repaints on scroll
+        https://bugs.webkit.org/show_bug.cgi?id=110430
+
+        Reviewed by Simon Fraser.
+
+        Test: compositing/repaint/scroll-fixed-layer-no-content.html
+        Test: compositing/repaint/scroll-fixed-layer-out-of-view.html
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::scrollContentsFastPath): Check for no-content and out-of-view flag set by RLC.
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::requiresCompositingForPosition): Moved the check for no-content above out-of-view because it's faster.
+
 2013-03-28  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -1665 +1665 @@
         ASSERT(renderer->hasLayer());
         RenderLayer* layer = toRenderBoxModelObject(renderer)->layer();
-        
+
+#if USE(ACCELERATED_COMPOSITING)
+        if (layer->viewportConstrainedNotCompositedReason() == RenderLayer::NotCompositedForBoundsOutOfView
+            || layer->viewportConstrainedNotCompositedReason() == RenderLayer::NotCompositedForNoVisibleContent) {
+            // Don't invalidate for invisible fixed layers.
+            continue;
+        }
+#endif
+
 #if ENABLE(CSS_FILTERS)
         if (layer->hasAncestorWithFilterOutsets()) {

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -2197 +2197 @@
     }
 
+    bool paintsContent = layer->isVisuallyNonEmpty() || layer->hasVisibleDescendant();
+    if (!paintsContent) {
+        if (viewportConstrainedNotCompositedReason)
+            *viewportConstrainedNotCompositedReason = RenderLayer::NotCompositedForNoVisibleContent;
+        return false;
+    }
+
     // Fixed position elements that are invisible in the current view don't get their own layer.
     if (FrameView* frameView = m_renderView->frameView()) {
@@ -2209 +2216 @@
     }
     
-    bool paintsContent = layer->isVisuallyNonEmpty() || layer->hasVisibleDescendant();
-    if (!paintsContent) {
-        if (viewportConstrainedNotCompositedReason)
-            *viewportConstrainedNotCompositedReason = RenderLayer::NotCompositedForNoVisibleContent;
-        return false;
-    }
-
     return true;
 }