Changeset 147133 in webkit

Timestamp:

Mar 28, 2013 11:13:10 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
​https://bugs.webkit.org/show_bug.cgi?id=113456

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

Use enum CanvasWindingRule type instead of DOMString for winding
arguments when needed. Changed methods are: fill, stroke and isPointInPath.

Test: fast/canvas/winding-enumeration.html

• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

When calling methods accepting a CanvasWindingRule with an invalid
string, check that a TypeError is thrown.

• fast/canvas/winding-enumeration-expected.txt: Added.
• fast/canvas/winding-enumeration.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/winding-enumeration-expected.txt (added)
• LayoutTests/fast/canvas/winding-enumeration.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/canvas/CanvasRenderingContext2D.idl (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-28  Arnaud Renevier  <a.renevier@sisa.samsung.com>
+
+        use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
+        https://bugs.webkit.org/show_bug.cgi?id=113456
+
+        Reviewed by Kentaro Hara.
+
+        When calling methods accepting a CanvasWindingRule with an invalid
+        string, check that a TypeError is thrown.
+
+        * fast/canvas/winding-enumeration-expected.txt: Added.
+        * fast/canvas/winding-enumeration.html: Added.
+
 2013-03-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-28  Arnaud Renevier  <a.renevier@sisa.samsung.com>
+
+        use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
+        https://bugs.webkit.org/show_bug.cgi?id=113456
+
+        Reviewed by Kentaro Hara.
+
+        Use enum CanvasWindingRule type instead of DOMString for winding
+        arguments when needed. Changed methods are: fill, stroke and isPointInPath.
+
+        Test: fast/canvas/winding-enumeration.html
+
+        * html/canvas/CanvasRenderingContext2D.idl:
+
 2013-03-28  Scott Graham  <scottmg@chromium.org>
 

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl

@@ -24 +24 @@
  */
 
-// FIXME: we should use CanvasWindingRule once support for WebIDL is completed. (bug #106553)
 enum CanvasWindingRule { "nonzero", "evenodd" };
 
@@ -135 +134 @@
         raises (DOMException);
 
-    void fill(in [Optional] DOMString winding);
+    void fill(in [Optional] CanvasWindingRule winding);
     void stroke();
-    void clip(in [Optional] DOMString winding);
+    void clip(in [Optional] CanvasWindingRule winding);
     boolean isPointInPath(in [Optional=DefaultIsUndefined] float x,
                           in [Optional=DefaultIsUndefined] float y,
-                          in [Optional] DOMString winding);
+                          in [Optional] CanvasWindingRule winding);
     boolean isPointInStroke(in [Optional=DefaultIsUndefined] float x,
                             in [Optional=DefaultIsUndefined] float y);