Changeset 147149 in webkit

Timestamp:

Mar 28, 2013 1:08:36 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

exceptions are not checked after toInt32 calls in bindings.
​https://bugs.webkit.org/show_bug.cgi?id=113218

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

In attribute setter, wrap JSValue to native value conversion in a try
catch block.

Define a new macro binding: V8TRYCATCH_VOID

No new tests: covered by fast/dom/exception-in-binding.html

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):

• bindings/v8/V8BindingMacros.h:

(WebCore):

LayoutTests:

• platform/chromium/TestExpectations: Enable fast/dom/exception-in-binding.html

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (modified) (1 diff)
• Source/WebCore/bindings/v8/V8BindingMacros.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-28  Arnaud Renevier  <a.renevier@sisa.samsung.com>
+
+        exceptions are not checked after toInt32 calls in bindings.
+        https://bugs.webkit.org/show_bug.cgi?id=113218
+
+        Reviewed by Kentaro Hara.
+
+        * platform/chromium/TestExpectations: Enable fast/dom/exception-in-binding.html
+
 2013-03-28  Roger Fong  <roger_fong@apple.com>
 

trunk/LayoutTests/platform/chromium/TestExpectations

@@ -3801 +3801 @@
 webkit.org/b/113114 media/video-controls-captions.html [ Timeout ]
 
-webkit.org/b/113219 fast/dom/exception-in-binding.html [ Failure ]
-
 webkit.org/b/113474 http/tests/cache/subresource-failover-to-network.html [ Pass Failure ]
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-28  Arnaud Renevier  <a.renevier@sisa.samsung.com>
+
+        exceptions are not checked after toInt32 calls in bindings.
+        https://bugs.webkit.org/show_bug.cgi?id=113218
+
+        Reviewed by Kentaro Hara.
+
+        In attribute setter, wrap JSValue to native value conversion in a try
+        catch block.
+
+        Define a new macro binding: V8TRYCATCH_VOID
+
+        No new tests: covered by fast/dom/exception-in-binding.html
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateNormalAttrSetter):
+        * bindings/v8/V8BindingMacros.h:
+        (WebCore):
+
 2013-03-28  ChangSeok Oh  <changseok.oh@collabora.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -1399 +1399 @@
             push(@implContentInternals, "    V8TRYCATCH_WITH_TYPECHECK_VOID($nativeType, v, $value, info.GetIsolate());\n");
         } else {
-            push(@implContentInternals, "    $nativeType v = $value;\n");
+            push(@implContentInternals, "    V8TRYCATCH_VOID($nativeType, v, $value);\n");
         }
     }

trunk/Source/WebCore/bindings/v8/V8BindingMacros.h

@@ -41 +41 @@
         if (block.HasCaught())            \
             return block.ReThrow();       \
+    }
+
+#define V8TRYCATCH_VOID(type, var, value) \
+    type var;                             \
+    {                                     \
+        v8::TryCatch block;               \
+        var = (value);                    \
+        if (block.HasCaught()) {          \
+            block.ReThrow();              \
+            return;                       \
+        }                                 \
     }