Changeset 147209 in webkit
- Timestamp:
- Mar 29, 2013 5:40:28 AM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r147208 r147209 1 2013-03-29 Andrey Lushnikov <lushnikov@chromium.org> 2 3 Web Inspector: ability to use AnchorBox as an anchor for Popover 4 https://bugs.webkit.org/show_bug.cgi?id=113563 5 6 Reviewed by Pavel Feldman. 7 8 No new test: no change in behaviour. 9 10 - Ability to pass AnchorBox instead of Element for popover anchor. 11 12 * inspector/front-end/Popover.js: 13 (WebInspector.Popover.prototype._positionElement): 14 (WebInspector.PopoverHelper.prototype._eventInHoverElement): 15 1 16 2013-03-29 Andrey Kosyakov <caseq@chromium.org> 2 17 -
trunk/Source/WebCore/inspector/front-end/Popover.js
r147027 r147209 54 54 /** 55 55 * @param {Element} element 56 * @param {Element } anchor56 * @param {Element|AnchorBox} anchor 57 57 * @param {?number=} preferredWidth 58 58 * @param {?number=} preferredHeight … … 66 66 /** 67 67 * @param {WebInspector.View} view 68 * @param {Element } anchor68 * @param {Element|AnchorBox} anchor 69 69 * @param {?number=} preferredWidth 70 70 * @param {?number=} preferredHeight … … 78 78 * @param {WebInspector.View?} view 79 79 * @param {Element} contentElement 80 * @param {Element } anchor80 * @param {Element|AnchorBox} anchor 81 81 * @param {?number=} preferredWidth 82 82 * @param {?number=} preferredHeight … … 138 138 }, 139 139 140 /** 141 * @param {Element|AnchorBox} anchorElement 142 * @param {number} preferredWidth 143 * @param {number} preferredHeight 144 * @param {?WebInspector.Popover.Orientation=} arrowDirection 145 */ 140 146 _positionElement: function(anchorElement, preferredWidth, preferredHeight, arrowDirection) 141 147 { … … 151 157 const totalHeight = window.innerHeight; 152 158 153 var anchorBox = anchorElement .boxInWindow(window);159 var anchorBox = anchorElement instanceof AnchorBox ? anchorElement : anchorElement.boxInWindow(window); 154 160 var newElementPosition = { x: 0, y: 0, width: preferredWidth + scrollerWidth, height: preferredHeight }; 155 161 … … 221 227 * @constructor 222 228 * @param {Element} panelElement 223 * @param {function(Element, Event): Element|undefined} getAnchor229 * @param {function(Element, Event):(Element|AnchorBox)|undefined} getAnchor 224 230 * @param {function(Element, WebInspector.Popover):undefined} showPopover 225 231 * @param {function()=} onHide … … 253 259 if (!this._hoverElement) 254 260 return false; 255 var box = this._hoverElement .boxInWindow();261 var box = this._hoverElement instanceof AnchorBox ? this._hoverElement : this._hoverElement.boxInWindow(); 256 262 return (box.x <= event.clientX && event.clientX <= box.x + box.width && 257 263 box.y <= event.clientY && event.clientY <= box.y + box.height);
Note: See TracChangeset
for help on using the changeset viewer.