Changeset 147209 in webkit


Ignore:
Timestamp:
Mar 29, 2013 5:40:28 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: ability to use AnchorBox as an anchor for Popover
https://bugs.webkit.org/show_bug.cgi?id=113563

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-29
Reviewed by Pavel Feldman.

No new test: no change in behaviour.

  • Ability to pass AnchorBox instead of Element for popover anchor.
  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):
(WebInspector.PopoverHelper.prototype._eventInHoverElement):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r147208 r147209  
     12013-03-29  Andrey Lushnikov  <lushnikov@chromium.org>
     2
     3        Web Inspector: ability to use AnchorBox as an anchor for Popover
     4        https://bugs.webkit.org/show_bug.cgi?id=113563
     5
     6        Reviewed by Pavel Feldman.
     7
     8        No new test: no change in behaviour.
     9
     10        - Ability to pass AnchorBox instead of Element for popover anchor.
     11
     12        * inspector/front-end/Popover.js:
     13        (WebInspector.Popover.prototype._positionElement):
     14        (WebInspector.PopoverHelper.prototype._eventInHoverElement):
     15
    1162013-03-29  Andrey Kosyakov  <caseq@chromium.org>
    217
  • trunk/Source/WebCore/inspector/front-end/Popover.js

    r147027 r147209  
    5454    /**
    5555     * @param {Element} element
    56      * @param {Element} anchor
     56     * @param {Element|AnchorBox} anchor
    5757     * @param {?number=} preferredWidth
    5858     * @param {?number=} preferredHeight
     
    6666    /**
    6767     * @param {WebInspector.View} view
    68      * @param {Element} anchor
     68     * @param {Element|AnchorBox} anchor
    6969     * @param {?number=} preferredWidth
    7070     * @param {?number=} preferredHeight
     
    7878     * @param {WebInspector.View?} view
    7979     * @param {Element} contentElement
    80      * @param {Element} anchor
     80     * @param {Element|AnchorBox} anchor
    8181     * @param {?number=} preferredWidth
    8282     * @param {?number=} preferredHeight
     
    138138    },
    139139
     140    /**
     141     * @param {Element|AnchorBox} anchorElement
     142     * @param {number} preferredWidth
     143     * @param {number} preferredHeight
     144     * @param {?WebInspector.Popover.Orientation=} arrowDirection
     145     */
    140146    _positionElement: function(anchorElement, preferredWidth, preferredHeight, arrowDirection)
    141147    {
     
    151157        const totalHeight = window.innerHeight;
    152158
    153         var anchorBox = anchorElement.boxInWindow(window);
     159        var anchorBox = anchorElement instanceof AnchorBox ? anchorElement : anchorElement.boxInWindow(window);
    154160        var newElementPosition = { x: 0, y: 0, width: preferredWidth + scrollerWidth, height: preferredHeight };
    155161
     
    221227 * @constructor
    222228 * @param {Element} panelElement
    223  * @param {function(Element, Event):Element|undefined} getAnchor
     229 * @param {function(Element, Event):(Element|AnchorBox)|undefined} getAnchor
    224230 * @param {function(Element, WebInspector.Popover):undefined} showPopover
    225231 * @param {function()=} onHide
     
    253259        if (!this._hoverElement)
    254260            return false;
    255         var box = this._hoverElement.boxInWindow();
     261        var box = this._hoverElement instanceof AnchorBox ? this._hoverElement : this._hoverElement.boxInWindow();
    256262        return (box.x <= event.clientX && event.clientX <= box.x + box.width &&
    257263            box.y <= event.clientY && event.clientY <= box.y + box.height);
Note: See TracChangeset for help on using the changeset viewer.