Changeset 147244 in webkit

Timestamp:

Mar 29, 2013 12:56:59 PM (11 years ago)

Author:

jsbell@chromium.org

Message:

IndexedDB: Use WTF::TemporaryChange rather than manually resetting a flag
​https://bugs.webkit.org/show_bug.cgi?id=113594

Reviewed by Tony Chang.

Split out from another patch: rather than m_foo = true; ... m_foo = false; use
the handy WTF::TemporaryChange scoped variable change doohickey.

Test: http/tests/inspector/indexeddb/database-structure.html

• Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::close):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/IDBDatabaseBackendImpl.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-29  Joshua Bell  <jsbell@chromium.org>
+
+        IndexedDB: Use WTF::TemporaryChange rather than manually resetting a flag
+        https://bugs.webkit.org/show_bug.cgi?id=113594
+
+        Reviewed by Tony Chang.
+
+        Split out from another patch: rather than m_foo = true; ... m_foo = false; use
+        the handy WTF::TemporaryChange scoped variable change doohickey.
+
+        Test: http/tests/inspector/indexeddb/database-structure.html
+
+        * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
+        (WebCore::IDBDatabaseBackendImpl::close):
+
 2013-03-29  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp

@@ -39 +39 @@
 #include "IDBTransactionCoordinator.h"
 #include "SharedBuffer.h"
+#include <wtf/TemporaryChange.h>
 
 namespace WebCore {
@@ -1335 +1336 @@
     if (m_closingConnection)
         return;
-    m_closingConnection = true;
+    TemporaryChange<bool> closingConnection(m_closingConnection, true);
     processPendingCalls();
 
@@ -1352 +1353 @@
             m_factory->removeIDBDatabaseBackend(m_identifier);
     }
-    m_closingConnection = false;
 }