Changeset 147275 in webkit


Ignore:
Timestamp:
Mar 30, 2013 1:24:38 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Fonts refactoring
https://bugs.webkit.org/show_bug.cgi?id=113047

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-30
Reviewed by Pavel Feldman.

Unify fonts usage across inspector.
Make inspector default font depend on platform.

Source/WebCore:

  • inspector/front-end/breakpointsList.css:
  • inspector/front-end/dataGrid.css:

(.data-grid):
(.data-grid table):
(.data-grid td):
(.data-grid th.sort-ascending > div::after):
(.data-grid th.sort-descending > div::after):
(.data-grid button):

  • inspector/front-end/heapProfiler.css:

(.heap-snapshot-view .class-view-toolbar input.class-name-filter):
(.heap-snapshot-view .retainers-view-header):

  • inspector/front-end/inspector.css:

(.toolbar-item):
(.toolbar-label):
(.console-message .bubble):
(.outline-disclosure > ol):
(.source-code):
(.scope-bar li):
(.sidebar-tree, .sidebar-tree .children):
(.sidebar-tree-section):
(li .status .bubble):
(.sidebar-tree-item.selected):
(.sidebar-tree-item .titles):
(.sidebar-tree-item .subtitle):
(.sidebar-tree-item.selected .subtitle):
(.source-frame-breakpoint-message):
(.soft-context-menu):

  • inspector/front-end/inspectorCommon.css:

(body):
(.resources-divider-label):

  • inspector/front-end/navigatorView.css:

(.navigator li):
(.navigator li.selected .selection):
(.navigator .base-navigator-tree-element-title):

  • inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):
(.network-log-grid.data-grid th):
(.network-log-grid.data-grid select):
(.network-graph-label):
(.network-timeline-grid .resources-divider-label):
(.network-log-grid.data-grid .network-summary-bar td):

  • inspector/front-end/resourcesPanel.css:

(.resources.panel .sidebar li):
(.resources.panel .sidebar li.selected):
(.resources.panel .sidebar li.selected .selection):

  • inspector/front-end/sidebarPane.css:

(.sidebar-pane > .body .info):
(.sidebar-pane-title):
(.sidebar-pane-toolbar):
(.sidebar-pane-subtitle):

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab-close-button):
(select.tabbed-pane-header-tabs-drop-down-select):

  • inspector/front-end/timelinePanel.css:

(.memory-counter-value):

Source/WebKit/chromium:

  • src/js/devTools.css:

(body.platform-linux):
(body.platform-mac):
(body.platform-windows):

Location:
trunk/Source
Files:
14 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r147267 r147275  
     12013-03-30  Alexei Filippov  <alph@chromium.org>
     2
     3        Web Inspector: Fonts refactoring
     4        https://bugs.webkit.org/show_bug.cgi?id=113047
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Unify fonts usage across inspector.
     9        Make inspector default font depend on platform.
     10
     11        * inspector/front-end/breakpointsList.css:
     12        * inspector/front-end/dataGrid.css:
     13        (.data-grid):
     14        (.data-grid table):
     15        (.data-grid td):
     16        (.data-grid th.sort-ascending > div::after):
     17        (.data-grid th.sort-descending > div::after):
     18        (.data-grid button):
     19        * inspector/front-end/heapProfiler.css:
     20        (.heap-snapshot-view .class-view-toolbar input.class-name-filter):
     21        (.heap-snapshot-view .retainers-view-header):
     22        * inspector/front-end/inspector.css:
     23        (.toolbar-item):
     24        (.toolbar-label):
     25        (.console-message .bubble):
     26        (.outline-disclosure > ol):
     27        (.source-code):
     28        (.scope-bar li):
     29        (.sidebar-tree, .sidebar-tree .children):
     30        (.sidebar-tree-section):
     31        (li .status .bubble):
     32        (.sidebar-tree-item.selected):
     33        (.sidebar-tree-item .titles):
     34        (.sidebar-tree-item .subtitle):
     35        (.sidebar-tree-item.selected .subtitle):
     36        (.source-frame-breakpoint-message):
     37        (.soft-context-menu):
     38        * inspector/front-end/inspectorCommon.css:
     39        (body):
     40        (.resources-divider-label):
     41        * inspector/front-end/navigatorView.css:
     42        (.navigator li):
     43        (.navigator li.selected .selection):
     44        (.navigator .base-navigator-tree-element-title):
     45        * inspector/front-end/networkLogView.css:
     46        (.network-log-grid.data-grid td):
     47        (.network-log-grid.data-grid.small td):
     48        (.network-log-grid.data-grid th):
     49        (.network-log-grid.data-grid select):
     50        (.network-graph-label):
     51        (.network-timeline-grid .resources-divider-label):
     52        (.network-log-grid.data-grid .network-summary-bar td):
     53        * inspector/front-end/resourcesPanel.css:
     54        (.resources.panel .sidebar li):
     55        (.resources.panel .sidebar li.selected):
     56        (.resources.panel .sidebar li.selected .selection):
     57        * inspector/front-end/sidebarPane.css:
     58        (.sidebar-pane > .body .info):
     59        (.sidebar-pane-title):
     60        (.sidebar-pane-toolbar):
     61        (.sidebar-pane-subtitle):
     62        * inspector/front-end/tabbedPane.css:
     63        (.tabbed-pane-header-tab):
     64        (.tabbed-pane-header-tab-close-button):
     65        (select.tabbed-pane-header-tabs-drop-down-select):
     66        * inspector/front-end/timelinePanel.css:
     67        (.memory-counter-value):
     68
    1692013-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
    270
  • trunk/Source/WebCore/inspector/front-end/breakpointsList.css

    r144927 r147275  
    9797
    9898.event-listener-breakpoints .event-category {
    99     font-size: 11px;
    100     font-weight: bold;
    101     color: rgb(96, 96, 96);
    10299    padding-top: 2px;
    103100}
     
    109106
    110107.event-listener-breakpoints .checkbox-elem {
    111     font-size: 10px;
    112108    float: left;
    113109    top: -2px;
  • trunk/Source/WebCore/inspector/front-end/dataGrid.css

    r146871 r147275  
    22    position: relative;
    33    border: 1px solid #aaa;
     4    font-size: 11px;
    45}
    56
     
    1718    border-collapse: collapse;
    1819    width: 100%;
    19     font-size: 11px;
    20     font-family: Lucida Grande, sans-serif;
    2120}
    2221
     
    103102    vertical-align: top;
    104103    height: 16px; /* Keep in sync with .data-grid table.data @ -webkit-background-size */
    105     line-height: 12px;
    106     padding: 2px 4px;
     104    line-height: 13px;
     105    padding: 1px 4px;
    107106    white-space: nowrap;
    108107    overflow: hidden;
     
    149148.data-grid th.sort-ascending > div::after {
    150149    position: absolute;
    151     top: 0;
    152     bottom: 0;
    153150    right: 0;
    154151    height: 12px;
     
    161158.data-grid th.sort-descending > div::after {
    162159    position: absolute;
    163     top: 0;
    164     bottom: 0;
    165160    right: 0;
    166161    height: 8px;
     
    173168.data-grid button {
    174169    line-height: 18px;
     170    color: inherit;
    175171}
    176172
  • trunk/Source/WebCore/inspector/front-end/heapProfiler.css

    r147103 r147275  
    215215    height: 18px;
    216216    font-size: 11px;
     217    font-family: inherit;
    217218    padding: 2px;
    218219    margin: 2px 10px;
     
    228229    cursor: row-resize;
    229230    height: 23px;
    230     font: -webkit-small-control;
    231     font-weight: bold;
    232     color: rgb(48, 48, 48);
    233     text-shadow: rgba(255, 255, 255, 0.75) 0 1px 0;
    234231    display: block;
    235232    position: absolute;
  • trunk/Source/WebCore/inspector/front-end/inspector.css

    r147221 r147275  
    101101    border-style: none;
    102102    border-color: transparent;
     103    color: inherit;
     104    font-family: inherit;
     105    font-size: inherit;
    103106}
    104107
     
    164167
    165168.toolbar-label {
    166     line-height: 22px;
    167     font-size: 11px;
    168     font-family: Lucida Grande, sans-serif;
     169    line-height: 23px;
    169170    text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
    170171}
     
    173174    line-height: 15px;
    174175}
     176
    175177.toolbar-item.toggleable:active .toolbar-label {
    176178    text-shadow: none;
     
    759761.status-bar select.status-bar-item:active,
    760762.status-bar button.status-bar-item:active {
    761     background-color: rgb(163,163,163);
    762763    border-left: 1px solid rgb(120, 120, 120);
    763764    border-right: 1px solid rgb(120, 120, 120);
     
    10471048    font-size: 11px;
    10481049    line-height: normal;
    1049     font-family: Helvetica, Arial, sans-serif;
    10501050    font-weight: bold;
    10511051    text-shadow: none;
     
    13941394}
    13951395
    1396 .outline-disclosure {
    1397     font-size: 11px;
    1398 }
    1399 
    14001396.outline-disclosure > ol {
    14011397    position: relative;
    14021398    padding: 2px 6px !important;
    14031399    margin: 0;
    1404     color: black;
    14051400    cursor: default;
    14061401    min-width: 100%;
     
    14151410.source-code {
    14161411    font-family: monospace;
    1417     font-size: 10px !important;
     1412    font-size: 11px !important;
    14181413    white-space: pre-wrap;
    14191414}
     
    14551450
    14561451.outline-disclosure li.parent::before {
    1457     content: url(Images/treeRightTriangleBlack.png);
    14581452    float: left;
    14591453    width: 8px;
     
    18981892    margin: 0 2px;
    18991893    padding: 2px 6px;
    1900     font-size: 11px;
    19011894    line-height: 12px;
    19021895    font-weight: bold;
     
    19801973    margin: 0;
    19811974    list-style: none;
    1982     font-size: 11px;
    19831975}
    19841976
     
    19901982    margin-top: 1px;
    19911983    color: rgb(92, 110, 129);
    1992     font-weight: bold;
    19931984    text-shadow: rgba(255, 255, 255, 0.75) 0 1px 0;
    19941985}
     
    21222113    font-size: 11px;
    21232114    line-height: normal;
    2124     font-family: Helvetica, Arial, sans-serif;
    21252115    font-weight: bold;
    21262116    text-shadow: none;
     
    21632153    border-top: 1px solid rgb(145, 160, 192);
    21642154    background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(162, 177, 207)), to(rgb(120, 138, 177)));
    2165     text-shadow: rgba(0, 0, 0, 0.33) 0 1px 0;
    2166     font-weight: bold;
     2155    text-shadow: rgba(0, 0, 0, 0.33) 1px 1px 0;
    21672156    -webkit-background-origin: padding;
    21682157    -webkit-background-clip: padding;
     
    21822171    position: relative;
    21832172    top: 5px;
    2184     line-height: 11px;
     2173    line-height: 12px;
    21852174    padding-bottom: 1px;
    21862175    text-overflow: ellipsis;
     
    22042193
    22052194.sidebar-tree-item .subtitle {
    2206     font-size: 9px;
    2207     color: rgba(0, 0, 0, 0.7);
     2195    font-size: 80%;
    22082196}
    22092197
     
    22132201
    22142202.sidebar-tree-item.selected .subtitle {
    2215     color: rgba(255, 255, 255, 0.9);
     2203    color: white;
    22162204}
    22172205
     
    23052293.source-frame-breakpoint-message {
    23062294    background-color: transparent;
    2307     font-family: Lucida Grande, sans-serif;
    23082295    font-weight: normal;
    23092296    font-size: 11px;
     
    24102397.soft-context-menu {
    24112398    position: absolute;
    2412     font-family: 'Lucida Grande', 'Helvetica', 'sans-serif';
    24132399    border: 1px solid rgba(196, 196, 196, 0.9);
    24142400    border-top: 1px solid rgba(196, 196, 196, 0.5);
     
    25162502
    25172503.drawer-header-close-button {
    2518     font-family: Arial, monospace;
    25192504    padding: 3px 8px;
    25202505    font-size: 14px;
  • trunk/Source/WebCore/inspector/front-end/inspectorCommon.css

    r146969 r147275  
    1212    overflow: hidden;
    1313    font-family: Lucida Grande, sans-serif;
    14     font-size: 10px;
     14    font-size: 11px;
    1515    margin: 0;
    1616    tab-size: 4;
     
    123123    top: 4px;
    124124    right: 3px;
    125     font-size: 9px;
    126     color: rgb(50%, 50%, 50%);
     125    font-size: 80%;
    127126    white-space: nowrap;
    128127    pointer-events: none;
  • trunk/Source/WebCore/inspector/front-end/navigatorView.css

    r144467 r147275  
    5959
    6060.navigator li {
    61     height: 17px;
     61    height: 18px;
     62    line-height: 17px;
    6263    white-space: nowrap;
    6364}
     
    6869
    6970.navigator li.selected .selection {
    70     height: 17px;
     71    height: 18px;
    7172    background-color: rgb(180, 180, 180);
    7273}
     
    99100    position: relative;
    100101    padding-left: 2px;
    101     top: 1px;
    102102}
    103103
  • trunk/Source/WebCore/inspector/front-end/networkLogView.css

    r146871 r147275  
    1919.network-log-grid.data-grid td {
    2020    line-height: 17px;
    21     height: 37px;
     21    height: 41px;
    2222    border-right: 1px solid rgb(210, 210, 210);
    2323    vertical-align: middle;
     
    2525
    2626.network-log-grid.data-grid.small td {
    27     height: 17px;
     27    height: 21px;
    2828}
    2929
     
    3131    border-bottom: 1px solid rgb(64%, 64%, 64%);
    3232    height: 30px;
    33     font-weight: bold;
    3433}
    3534
     
    5554    border: none;
    5655    width: 100%;
    57     font-weight: bold;
     56    font-size: inherit;
     57    color: inherit;
    5858}
    5959
     
    7575
    7676.network-log-grid.data-grid tr:not(.filler) td.name-column {
    77     font-weight: bold;
    7877    cursor: pointer;
    7978}
     
    241240    height: 13px;
    242241    line-height: 13px;
    243     font-size: 9px;
     242    font-size: 90%;
    244243    color: rgba(0, 0, 0, 0.75);
    245244    text-shadow: rgba(255, 255, 255, 0.25) 1px 0 0, rgba(255, 255, 255, 0.25) -1px 0 0, rgba(255, 255, 255, 0.333) 0 1px 0, rgba(255, 255, 255, 0.25) 0 -1px 0;
     
    247246    overflow: hidden;
    248247    text-align: center;
    249     font-weight: bold;
    250248    opacity: 0;
    251249    -webkit-transition: opacity 250ms ease-in-out;
     
    443441.network-timeline-grid .resources-divider-label {
    444442    top: 0;
    445     margin-top: -4px;
    446     color: black;
     443    margin-top: -5px;
    447444}
    448445
     
    487484    height: 20px !important;
    488485    border: none;
    489     font-weight: bold;
     486    font-size: 110%;
    490487    padding: 0 0 0 8px;
    491488    white-space: pre;
  • trunk/Source/WebCore/inspector/front-end/resourcesPanel.css

    r145168 r147275  
    3838
    3939.resources.panel .sidebar li {
    40     height: 17px;
     40    height: 18px;
    4141    white-space: nowrap;
    4242}
     
    4444.resources.panel .sidebar li.selected {
    4545    color: white;
    46     text-shadow: rgba(0, 0, 0, 0.33) 0 1px 0;
    47     font-weight: bold;
     46    text-shadow: rgba(0, 0, 0, 0.33) 1px 1px 0;
    4847}
    4948
     
    5150    background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(162, 177, 207)), to(rgb(120, 138, 177)));
    5251    border-top: 1px solid #979797;
    53     height: 17px;
     52    height: 18px;
    5453}
    5554
  • trunk/Source/WebCore/inspector/front-end/sidebarPane.css

    r144927 r147275  
    4242    text-align: center;
    4343    font-style: italic;
    44     font-size: 10px;
     44    font-size: 90%;
    4545    padding: 6px;
    46     color: black;
     46    color: #888;
    4747}
    4848
     
    7272.sidebar-pane-title {
    7373    position: relative;
    74     background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(243, 243, 243)), color-stop(0.05, rgb(243, 243, 243)), color-stop(0.05, rgb(230, 230, 230)), to(rgb(209, 209, 209)));
     74    background: rgb(230, 230, 230);
    7575    height: 20px;
    7676    padding: 0 5px;
    7777    border-top: 1px solid rgb(189, 189, 189);
    7878    border-bottom: 1px solid rgb(189, 189, 189);
    79     font-weight: bold;
    80     font-size: 12px;
    8179    line-height: 18px;
    82     color: rgb(110, 110, 110);
    83     text-shadow: white 0 1px 0;
    8480    -webkit-background-origin: padding;
    8581    -webkit-background-clip: padding;
     
    111107
    112108.sidebar-pane-toolbar {
    113     font-weight: bold;
    114     font-size: 12px;
    115109    line-height: 18px;
    116     color: rgb(110, 110, 110);
    117     text-shadow: white 0 1px 0;
    118110    left: 0;
    119     right: 0;
     111    right: 4px;
    120112    top: 0;
    121113    height: 20px;
     
    165157    position: absolute;
    166158    right: 0;
    167     font-weight: normal;
    168159}
    169160
  • trunk/Source/WebCore/inspector/front-end/tabbedPane.css

    r146871 r147275  
    6363    float: left;
    6464    margin-top: 2px;
    65     font-size: 11px;
    66     font-weight: bold;
    67     color: rgb(46, 46, 46);
    68     background: transparent;
    69     text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
    70     vertical-align: middle;
    71     padding: 3px 4px 2px 4px;
     65    padding: 2px 4px 2px 4px;
    7266    height: 21px;
    7367    border: 1px solid transparent;
    7468    border-bottom: none;
     69    line-height: 15px;
    7570   
    7671    white-space: nowrap;
     
    8984}
    9085
    91 .tabbed-pane-header .tabbed-pane-header-tab-title {
    92     vertical-align: top;
    93 }
    94 
    9586.tabbed-pane-header-tab-close-button {
    96     font-family: Arial, monospace;
    9787    position: relative;
    98     bottom: 1px;
     88    bottom: 0;
    9989    opacity: 0;
    10090    padding-left: 3px;
    10191    font-size: 14px;
    10292    color: rgb(80, 80, 80);
     93    line-height: 12px;
    10394}
    10495
     
    165156    -webkit-appearance: none;
    166157}
    167  
  • trunk/Source/WebCore/inspector/front-end/timelinePanel.css

    r146871 r147275  
    213213
    214214.timeline-tree-item .count {
    215     font-family: Helvetica, Arial, sans-serif;
    216215    font-weight: bold;
    217216}
     
    360359
    361360.timeline-records-stats, .storage-application-cache-status, .storage-application-cache-connectivity {
    362     font-size: 11px;
    363361    text-shadow: white 0 1px 0;
    364362}
     
    497495
    498496.memory-counter-sidebar-info {
    499     font-size: 11px;
    500497    margin: 10px;
    501498}
     
    515512.memory-counter-value {
    516513    margin: 4px;
    517     font-size: 11px;
    518514}
    519515
  • trunk/Source/WebKit/chromium/ChangeLog

    r147256 r147275  
     12013-03-30  Alexei Filippov  <alph@chromium.org>
     2
     3        Web Inspector: Fonts refactoring
     4        https://bugs.webkit.org/show_bug.cgi?id=113047
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Unify fonts usage across inspector.
     9        Make inspector default font depend on platform.
     10
     11        * src/js/devTools.css:
     12        (body.platform-linux):
     13        (body.platform-mac):
     14        (body.platform-windows):
     15
    1162013-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
    217
  • trunk/Source/WebKit/chromium/src/js/devTools.css

    r146871 r147275  
    1212
    1313/* Chrome theme overrides */
     14
     15body.platform-linux {
     16  color: rgb(48, 57, 66);
     17  font-family: Ubuntu, Arial, sans-serif;
     18  font-size: 12px;
     19}
     20
     21body.platform-mac {
     22  color: rgb(48, 57, 66);
     23  font-family: 'Lucida Grande', sans-serif;
     24  font-size: 12px;
     25}
     26
     27body.platform-windows {
     28  font-family: 'Segoe UI', Tahoma, sans-serif;
     29  font-size: 12px;
     30}
    1431
    1532body.platform-windows #toolbar, body.platform-windows.inactive #toolbar {
Note: See TracChangeset for help on using the changeset viewer.