Changeset 147314 in webkit

Timestamp:

Apr 1, 2013 3:25:43 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Fixed DOM Breakpoint pane styles.
​https://bugs.webkit.org/show_bug.cgi?id=113688

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

The required stylesheet (breakpointsList.css) was not loaded because of
the peculiar way DOMBreakpointsSidebarPane is included in two panels
(Sources and Elements) via a proxy pane. Since DOMBreakpointsSidebarPane
was never shown directly the registerRequiredCSS call in its base class
NativeBreakpointsSidebarPane constructor had no effect.
Addin a registerRequiredCSS call to the proxy pane constructor fixes the
problem.

• inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.Proxy):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DOMBreakpointsSidebarPane.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-01  Vladislav Kaznacheev  <kaznacheev@chromium.org>
+
+        Web Inspector: Fixed DOM Breakpoint pane styles.
+        https://bugs.webkit.org/show_bug.cgi?id=113688
+
+        Reviewed by Pavel Feldman.
+
+        The required stylesheet (breakpointsList.css) was not loaded because of
+        the peculiar way DOMBreakpointsSidebarPane is included in two panels
+        (Sources and Elements) via a proxy pane. Since DOMBreakpointsSidebarPane
+        was never shown directly the registerRequiredCSS call in its base class
+        NativeBreakpointsSidebarPane constructor had no effect.
+        Addin a registerRequiredCSS call to the proxy pane constructor fixes the
+        problem.
+
+
+        * inspector/front-end/DOMBreakpointsSidebarPane.js:
+        (WebInspector.DOMBreakpointsSidebarPane.Proxy):
+
 2013-04-01  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js

@@ -358 +358 @@
 
     WebInspector.SidebarPane.call(this, pane.title());
+    this.registerRequiredCSS("breakpointsList.css");
 
     this._wrappedPane = pane;