Changeset 147343 in webkit


Ignore:
Timestamp:
Apr 1, 2013 11:05:48 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
​https://bugs.webkit.org/show_bug.cgi?id=113549

Patch by James Craig <​james@cookiecrook.com> on 2013-04-01
Reviewed by Chris Fleizach.

Source/WebCore:

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.
Also cleaned up some erroneous comments related to the sub-level controls on these elements.

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaControlElementString):

Source/WebCore/platform/gtk/po:

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.

  • en_CA.po:
  • en_GB.po:

LayoutTests:

Updating the video/audio element's default accessibility labels to be less verbose.

  • platform/gtk/accessibility/media-controls-panel-title-expected.txt:
  • platform/gtk/accessibility/media-controls-panel-title.html:
  • platform/gtk/accessibility/media-element-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
Location:
trunk
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r147325 r147343  
     12013-04-01  James Craig  <james@cookiecrook.com>
     2
     3        AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
     4        https://bugs.webkit.org/show_bug.cgi?id=113549
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Updating the video/audio element's default accessibility labels to be less verbose.
     9
     10        * platform/gtk/accessibility/media-controls-panel-title-expected.txt:
     11        * platform/gtk/accessibility/media-controls-panel-title.html:
     12        * platform/gtk/accessibility/media-element-expected.txt:
     13        * platform/mac/accessibility/media-element-expected.txt:
     14
    1152013-04-01  Victor Carbune  <vcarbune@chromium.org>
    216

  • trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title-expected.txt

    r132091 r147343  
    77PASS element.title is 'AXTitle: '
    88PASS element.role is 'AXRole: AXToolbar'
    9 PASS element.title is 'AXTitle: video element controller'
     9PASS element.title is 'AXTitle: video playback'
    1010PASS successfullyParsed is true
    1111

  • trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title.html

    r132091 r147343  
    1818    element = element.childAtIndex(0);
    1919    shouldBe("element.role", "'AXRole: AXToolbar'");
    20     shouldBe("element.title", "'AXTitle: video element controller'");
     20    shouldBe("element.title", "'AXTitle: video playback'");
    2121}
    2222

  • trunk/LayoutTests/platform/gtk/accessibility/media-element-expected.txt

    r143463 r147343  
    55State at 'canplaythrough' event:
    66
    7     description: AXDescription: video element controller
     7    description: AXDescription: video playback
    88    role: AXRole: AXToolbar
    99
    1010
    11         description: AXDescription: video element controller
     11        description: AXDescription: video playback
    1212        role: AXRole: AXToolbar
    1313

  • trunk/LayoutTests/platform/mac/accessibility/media-element-expected.txt

    r111041 r147343  
    55State at 'canplaythrough' event:
    66
    7     description: AXDescription: video element controller
     7    description: AXDescription: video playback
    88    role: AXRole: AXToolbar
    99

  • trunk/Source/WebCore/ChangeLog

    r147336 r147343  
     12013-04-01  James Craig  <james@cookiecrook.com>
     2
     3        AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
     4        https://bugs.webkit.org/show_bug.cgi?id=113549
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Existing test coverage.
     9
     10        Updating the video/audio element's default accessibility labels to be less verbose.
     11        Also cleaned up some erroneous comments related to the sub-level controls on these elements.
     12
     13        * English.lproj/Localizable.strings:
     14        * platform/LocalizedStrings.cpp:
     15        (WebCore::localizedMediaControlElementString):
     16        (WebCore::localizedMediaControlElementHelpText):
     17        * platform/gtk/LocalizedStringsGtk.cpp:
     18        (WebCore::localizedMediaControlElementString):
     19
    1202013-04-01  Nate Chapin  <japhet@chromium.org>
    221

  • trunk/Source/WebCore/English.lproj/Localizable.strings

    r146380 r147343  
    590590"article" = "article";
    591591
    592 /* accessibility role description for audio element controller */
    593 "audio element controller" = "audio element controller";
    594 
    595 /* accessibility role description for audio element controller */
     592/* accessibility label for audio element controller */
     593"audio playback" = "audio playback";
     594
     595/* accessibility help text for audio element controller */
    596596"audio element playback controls and status display" = "audio element playback controls and status display";
    597597
    598 /* accessibility role description for seek back 30 seconds button */
     598/* accessibility label for seek back 30 seconds button */
    599599"back 30 seconds" = "back 30 seconds";
    600600
    … …  
    650650"document" = "document";
    651651
    652 /* accessibility role description for elapsed time display */
     652/* accessibility label for elapsed time display */
    653653"elapsed time" = "elapsed time";
    654654
    655 /* accessibility role description for enter fullscreen button */
     655/* accessibility label for enter fullscreen button */
    656656"enter fullscreen" = "enter fullscreen";
    657657
    658 /* accessibility role description for exit fullscreen button */
     658/* accessibility label for exit fullscreen button */
    659659"exit fullscreen" = "exit fullscreen";
    660660
    … …  
    662662"expectation failed" = "expectation failed";
    663663
    664 /* accessibility role description for fast forward button */
     664/* accessibility label for fast forward button */
    665665"fast forward" = "fast forward";
    666666
    667 /* accessibility role description for fast reverse button */
     667/* accessibility label for fast reverse button */
    668668"fast reverse" = "fast reverse";
    669669
    … …  
    731731"moved permanently" = "moved permanently";
    732732
    733 /* accessibility role description for timeline slider */
     733/* accessibility label for timeline slider */
    734734"movie time" = "movie time";
    735735
    … …  
    743743"multiple choices" = "multiple choices";
    744744
    745 /* accessibility role description for mute button */
     745/* accessibility label for mute button */
    746746"mute" = "mute";
    747747
    … …  
    791791"pattern mismatch" = "pattern mismatch";
    792792
    793 /* accessibility role description for pause button */
     793/* accessibility label for pause button */
    794794"pause" = "pause";
    795795
    … …  
    800800"payment required" = "payment required";
    801801
    802 /* accessibility role description for play button */
     802/* accessibility label for play button */
    803803"play" = "play";
    804804
    … …  
    824824"region" = "region";
    825825
    826 /* accessibility role description for time remaining display */
     826/* accessibility label for time remaining display */
    827827"remaining time" = "remaining time";
    828828
    … …  
    845845"return streaming movie to real time" = "return streaming movie to real time";
    846846
    847 /* accessibility role description for return to real time button */
     847/* accessibility label for return to real time button */
    848848"return to realtime" = "return to realtime";
    849849
    … …  
    872872"service unavailable" = "service unavailable";
    873873
    874 /* accessibility role description for show closed captions button */
     874/* accessibility label for show closed captions button */
    875875"show closed captions" = "show closed captions";
    876876
    … …  
    878878"start displaying closed captions" = "start displaying closed captions";
    879879
    880 /* accessibility role description for movie status */
     880/* accessibility label for movie status */
    881881"status" = "status";
    882882
    … …  
    902902"term" = "term";
    903903
    904 /* accessibility role description for timeline thumb */
     904/* accessibility label for timeline thumb */
    905905"timeline slider thumb" = "timeline slider thumb";
    906906
    … …  
    932932"unknown" = "unknown";
    933933
    934 /* accessibility role description for turn mute off button */
     934/* accessibility label for turn mute off button */
    935935"unmute" = "unmute";
    936936
    … …  
    947947"value missing" = "value missing";
    948948
    949 /* accessibility role description for video element controller */
    950 "video element controller" = "video element controller";
    951 
    952 /* accessibility role description for video element controller */
     949/* default accessibility label for video element controller */
     950"video playback" = "video playback";
     951
     952/* accessibility help text for video element controller */
    953953"video element playback controls and status display" = "video element playback controls and status display";
    954954

  • trunk/Source/WebCore/platform/LocalizedStrings.cpp

    r146380 r147343  
    816816{
    817817    if (name == "AudioElement")
    818         return WEB_UI_STRING("audio element controller", "accessibility role description for audio element controller");
     818        return WEB_UI_STRING("audio playback", "accessibility label for audio element controller");
    819819    if (name == "VideoElement")
    820         return WEB_UI_STRING("video element controller", "accessibility role description for video element controller");
     820        return WEB_UI_STRING("video playback", "accessibility label for video element controller");
    821821    if (name == "MuteButton")
    822         return WEB_UI_STRING("mute", "accessibility role description for mute button");
     822        return WEB_UI_STRING("mute", "accessibility label for mute button");
    823823    if (name == "UnMuteButton")
    824         return WEB_UI_STRING("unmute", "accessibility role description for turn mute off button");
     824        return WEB_UI_STRING("unmute", "accessibility label for turn mute off button");
    825825    if (name == "PlayButton")
    826         return WEB_UI_STRING("play", "accessibility role description for play button");
     826        return WEB_UI_STRING("play", "accessibility label for play button");
    827827    if (name == "PauseButton")
    828         return WEB_UI_STRING("pause", "accessibility role description for pause button");
     828        return WEB_UI_STRING("pause", "accessibility label for pause button");
    829829    if (name == "Slider")
    830         return WEB_UI_STRING("movie time", "accessibility role description for timeline slider");
     830        return WEB_UI_STRING("movie time", "accessibility label for timeline slider");
    831831    if (name == "SliderThumb")
    832         return WEB_UI_STRING("timeline slider thumb", "accessibility role description for timeline thumb");
     832        return WEB_UI_STRING("timeline slider thumb", "accessibility label for timeline thumb");
    833833    if (name == "RewindButton")
    834         return WEB_UI_STRING("back 30 seconds", "accessibility role description for seek back 30 seconds button");
     834        return WEB_UI_STRING("back 30 seconds", "accessibility label for seek back 30 seconds button");
    835835    if (name == "ReturnToRealtimeButton")
    836         return WEB_UI_STRING("return to realtime", "accessibility role description for return to real time button");
     836        return WEB_UI_STRING("return to realtime", "accessibility label for return to real time button");
    837837    if (name == "CurrentTimeDisplay")
    838         return WEB_UI_STRING("elapsed time", "accessibility role description for elapsed time display");
     838        return WEB_UI_STRING("elapsed time", "accessibility label for elapsed time display");
    839839    if (name == "TimeRemainingDisplay")
    840         return WEB_UI_STRING("remaining time", "accessibility role description for time remaining display");
     840        return WEB_UI_STRING("remaining time", "accessibility label for time remaining display");
    841841    if (name == "StatusDisplay")
    842         return WEB_UI_STRING("status", "accessibility role description for movie status");
     842        return WEB_UI_STRING("status", "accessibility label for movie status");
    843843    if (name == "EnterFullscreenButton")
    844         return WEB_UI_STRING("enter fullscreen", "accessibility role description for enter fullscreen button");
     844        return WEB_UI_STRING("enter fullscreen", "accessibility label for enter fullscreen button");
    845845    if (name == "ExitFullscreenButton")
    846         return WEB_UI_STRING("exit fullscreen", "accessibility role description for exit fullscreen button");
     846        return WEB_UI_STRING("exit fullscreen", "accessibility label for exit fullscreen button");
    847847    if (name == "SeekForwardButton")
    848         return WEB_UI_STRING("fast forward", "accessibility role description for fast forward button");
     848        return WEB_UI_STRING("fast forward", "accessibility label for fast forward button");
    849849    if (name == "SeekBackButton")
    850         return WEB_UI_STRING("fast reverse", "accessibility role description for fast reverse button");
     850        return WEB_UI_STRING("fast reverse", "accessibility label for fast reverse button");
    851851    if (name == "ShowClosedCaptionsButton")
    852         return WEB_UI_STRING("show closed captions", "accessibility role description for show closed captions button");
     852        return WEB_UI_STRING("show closed captions", "accessibility label for show closed captions button");
    853853    if (name == "HideClosedCaptionsButton")
    854         return WEB_UI_STRING("hide closed captions", "accessibility role description for hide closed captions button");
     854        return WEB_UI_STRING("hide closed captions", "accessibility label for hide closed captions button");
    855855
    856856    // FIXME: the ControlsPanel container should never be visible in the accessibility hierarchy.
    … …  
    865865{
    866866    if (name == "AudioElement")
    867         return WEB_UI_STRING("audio element playback controls and status display", "accessibility role description for audio element controller");
     867        return WEB_UI_STRING("audio element playback controls and status display", "accessibility help text for audio element controller");
    868868    if (name == "VideoElement")
    869         return WEB_UI_STRING("video element playback controls and status display", "accessibility role description for video element controller");
     869        return WEB_UI_STRING("video element playback controls and status display", "accessibility help text for video element controller");
    870870    if (name == "MuteButton")
    871871        return WEB_UI_STRING("mute audio tracks", "accessibility help text for mute button");

  • trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp

    r143232 r147343  
    533533{
    534534    if (name == "AudioElement")
    535         return String::fromUTF8(_("audio element controller"));
     535        return String::fromUTF8(_("audio playback"));
    536536    if (name == "VideoElement")
    537         return String::fromUTF8(_("video element controller"));
     537        return String::fromUTF8(_("video playback"));
    538538    if (name == "MuteButton")
    539539        return String::fromUTF8(_("mute"));

  • trunk/Source/WebCore/platform/gtk/po/ChangeLog

    r147015 r147343  
     12013-04-01  James Craig  <james@cookiecrook.com>
     2
     3        AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
     4        https://bugs.webkit.org/show_bug.cgi?id=113549
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Existing test coverage.
     9
     10        Updating the video/audio element's default accessibility labels to be less verbose.
     11
     12        * en_CA.po:
     13        * en_GB.po:
     14
    1152013-03-27  Shantha kumar  <shkumar@redhat.com>
    216

  • trunk/Source/WebCore/platform/gtk/po/en_CA.po

    r145936 r147343  
    376376
    377377#: LocalizedStringsGtk.cpp:535
    378 msgid "audio element controller"
    379 msgstr "audio element controller"
     378msgid "audio playback"
     379msgstr "audio playback"
    380380
    381381#: LocalizedStringsGtk.cpp:537
    382 msgid "video element controller"
    383 msgstr "video element controller"
     382msgid "video playback"
     383msgstr "video playback"
    384384
    385385#: LocalizedStringsGtk.cpp:539

  • trunk/Source/WebCore/platform/gtk/po/en_GB.po

    r145936 r147343  
    378378
    379379#: LocalizedStringsGtk.cpp:535
    380 msgid "audio element controller"
    381 msgstr "audio element controller"
     380msgid "audio playback"
     381msgstr "audio playback"
    382382
    383383#: LocalizedStringsGtk.cpp:537
    384 msgid "video element controller"
    385 msgstr "video element controller"
     384msgid "video playback"
     385msgstr "video playback"
    386386
    387387#: LocalizedStringsGtk.cpp:539
Note: See TracChangeset for help on using the changeset viewer.