Changeset 147389 in webkit


Ignore:
Timestamp:
Apr 1, 2013 11:16:22 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Hide non-coordinated scrollbars for Android M26
https://bugs.webkit.org/show_bug.cgi?id=113738

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-04-01
Reviewed by Simon Fraser.

This patch will hide any non-coordinated scrollbars on Android.
Coordinated scrollbars won't be affected.

Currently all scrollbars are coordinated on Android. The sole purpose
of this patch is to be cherry-picked to the M26 branch.

No new tests. Please revert immediately after landed.

  • platform/ScrollView.cpp:

(WebCore::positionScrollbarLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r147388 r147389  
     12013-04-01  Tien-Ren Chen  <trchen@chromium.org>
     2
     3        Hide non-coordinated scrollbars for Android M26
     4        https://bugs.webkit.org/show_bug.cgi?id=113738
     5
     6        Reviewed by Simon Fraser.
     7
     8        This patch will hide any non-coordinated scrollbars on Android.
     9        Coordinated scrollbars won't be affected.
     10
     11        Currently all scrollbars are coordinated on Android. The sole purpose
     12        of this patch is to be cherry-picked to the M26 branch.
     13
     14        No new tests. Please revert immediately after landed.
     15
     16        * platform/ScrollView.cpp:
     17        (WebCore::positionScrollbarLayer):
     18        * rendering/RenderLayerBacking.cpp:
     19        (WebCore::RenderLayerBacking::positionOverflowControlsLayers):
     20
    1212013-04-01  Chris Evans  <cevans@google.com>
    222
  • trunk/Source/WebCore/platform/ScrollView.cpp

    r147039 r147389  
    917917    }
    918918
     919#if OS(ANDROID)
     920    graphicsLayer->setDrawsContent(false);
     921#else
    919922    graphicsLayer->setDrawsContent(true);
     923#endif
    920924    graphicsLayer->setNeedsDisplay();
    921925}
  • trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

    r147204 r147389  
    10901090                layer->setContentsRect(IntRect(IntPoint(), hBar->frameRect().size()));
    10911091        }
     1092#if OS(ANDROID)
     1093        layer->setDrawsContent(false);
     1094#else
    10921095        layer->setDrawsContent(hBar && !layer->hasContentsLayer());
     1096#endif
    10931097    }
    10941098   
     
    11011105                layer->setContentsRect(IntRect(IntPoint(), vBar->frameRect().size()));
    11021106        }
     1107#if OS(ANDROID)
     1108        layer->setDrawsContent(false);
     1109#else
    11031110        layer->setDrawsContent(vBar && !layer->hasContentsLayer());
     1111#endif
    11041112    }
    11051113
Note: See TracChangeset for help on using the changeset viewer.