Changeset 147410 in webkit

Timestamp:

Apr 2, 2013 2:50:11 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Empty tooltip shown when hovering over popup menu items
​https://bugs.webkit.org/show_bug.cgi?id=113382

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Gyuyoung Kim.

Do not show the empty tooltip box if the text is null.

• MiniBrowser/efl/main.c:

(popup_menu_populate):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/efl/main.c (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
+
+        [EFL][WK2] Empty tooltip shown when hovering over popup menu items
+        https://bugs.webkit.org/show_bug.cgi?id=113382
+
+        Reviewed by Gyuyoung Kim.
+
+        Do not show the empty tooltip box if the text is null.
+
+        * MiniBrowser/efl/main.c:
+        (popup_menu_populate):
+
 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/MiniBrowser/efl/main.c

@@ -930 +930 @@
             } else {
                 Elm_Object_Item *item = elm_menu_item_add(elm_menu, NULL, NULL, ewk_popup_menu_item_text_get(ewk_item), on_popup_menu_item_clicked, user_data);
-                elm_object_item_tooltip_text_set(item, ewk_popup_menu_item_tooltip_get(ewk_item));
+                const char *tooltip_text = ewk_popup_menu_item_tooltip_get(ewk_item);
+                if (tooltip_text && tooltip_text[0] != '\0')
+                    elm_object_item_tooltip_text_set(item, tooltip_text);
                 elm_object_item_disabled_set(item, !ewk_popup_menu_item_enabled_get(ewk_item));
                 elm_menu_item_selected_set(item, ewk_popup_menu_item_selected_get(ewk_item));