Changeset 147425 in webkit

Timestamp:

Apr 2, 2013 6:46:45 AM (11 years ago)

Author:

caseq@chromium.org

Message:

Web Inspector: ignore minimum record duration filter in Timeline overview
​https://bugs.webkit.org/show_bug.cgi?id=113705

Reviewed by Pavel Feldman.

• inspector/front-end/TimelineOverviewPane.js:
• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._durationFilterChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelineOverviewPane.js (modified) (4 diffs)
• inspector/front-end/TimelinePanel.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-02  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: ignore minimum record duration filter in Timeline overview
+        https://bugs.webkit.org/show_bug.cgi?id=113705
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/TimelineOverviewPane.js:
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._durationFilterChanged):
+
 2013-03-29  Andrey Kosyakov  <caseq@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js

@@ -316 +316 @@
     },
 
-    /**
-     * @param {number} value
-     */
-    setMinimumRecordDuration: function(value)
-    {
-        this._eventOverview.setMinimumRecordDuration(value);
-    },
-
     _scheduleRefresh: function()
     {
@@ -536 +528 @@
 
     this._context = this._canvas.getContext("2d");
-    this._minimumRecordDuration = 0;
 
     this._fillStyles = {};
@@ -579 +570 @@
         function appendRecord(record)
         {
-            if (!!this._minimumRecordDuration && (WebInspector.TimelineModel.durationInSeconds(record) < this._minimumRecordDuration))
-                return;
             if (record.type === WebInspector.TimelineModel.RecordType.BeginFrame)
                 return;
@@ -607 +596 @@
     },
 
-    /**
-     * @param {number} value
-     */
-    setMinimumRecordDuration: function(value)
-    {
-        this._minimumRecordDuration = value;
-        this.update();
-    },
-
     _renderBar: function(begin, end, category)
     {

trunk/Source/WebCore/inspector/front-end/TimelinePanel.js

@@ -603 +603 @@
         var minimumRecordDuration = +option._durationMs / 1000.0;
         this._durationFilter.setMinimumRecordDuration(minimumRecordDuration);
-        this._overviewPane.setMinimumRecordDuration(minimumRecordDuration);
         this._durationFilterSelector.element.title = option.title;
         this._invalidateAndScheduleRefresh(true, true);