Changeset 147433 in webkit

Timestamp:

Apr 2, 2013 7:58:05 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: source location gets frozen after inspector reload
​https://bugs.webkit.org/show_bug.cgi?id=113776

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Put statusBarText item in its own container and update its contents in
ScriptsPanel._updateScriptViewStatusBarItems in similar way it's done
for statusBarItems.

No new tests.

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.statusBarText):
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ScriptsPanel.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-02  Andrey Lushnikov  <lushnikov@chromium.org>
+
+        Web Inspector: source location gets frozen after inspector reload
+        https://bugs.webkit.org/show_bug.cgi?id=113776
+
+        Reviewed by Pavel Feldman.
+
+        Put statusBarText item in its own container and update its contents in
+        ScriptsPanel._updateScriptViewStatusBarItems in similar way it's done
+        for statusBarItems.
+
+        No new tests.
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel):
+        (WebInspector.ScriptsPanel.prototype.statusBarText):
+        (WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
+
 2013-04-02  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
 

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -148 +148 @@
     this._scriptViewStatusBarItemsContainer.style.display = "inline-block";
 
+    this._scriptViewStatusBarTextContainer = document.createElement("div");
+    this._scriptViewStatusBarTextContainer.style.display = "inline-block";
+
     this._installDebuggerSidebarController();
 
@@ -195 +198 @@
     statusBarText: function()
     {
-        var sourceFrame = this.visibleView;
-        return sourceFrame ? sourceFrame.statusBarText() : null;
+        return this._scriptViewStatusBarTextContainer;
     },
 
@@ -370 +372 @@
     {
         this._scriptViewStatusBarItemsContainer.removeChildren();
+        this._scriptViewStatusBarTextContainer.removeChildren();
 
         var sourceFrame = this.visibleView;
@@ -376 +379 @@
             for (var i = 0; i < statusBarItems.length; ++i)
                 this._scriptViewStatusBarItemsContainer.appendChild(statusBarItems[i]);
+            var statusBarText = sourceFrame.statusBarText();
+            if (statusBarText)
+                this._scriptViewStatusBarTextContainer.appendChild(statusBarText);
         }
     },