Changeset 147453 in webkit


Ignore:
Timestamp:
Apr 2, 2013 10:50:59 AM (11 years ago)
Author:
jochen@chromium.org
Message:

When computing the percentage of the logical height, use the logical top and bottom
https://bugs.webkit.org/show_bug.cgi?id=113761

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/writing-mode/percentage-height-orthogonal-writing-modes.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests:

  • fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt:
  • fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r147450 r147453  
     12013-04-02  Jochen Eisinger  <jochen@chromium.org>
     2
     3        When computing the percentage of the logical height, use the logical top and bottom
     4        https://bugs.webkit.org/show_bug.cgi?id=113761
     5
     6        Reviewed by Ojan Vafai.
     7
     8        * fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt:
     9        * fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
     10
    1112013-04-02  Nate Chapin  <japhet@chromium.org>
    212
  • trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt

    r138838 r147453  
    77PASS
    88PASS
     9PASS
  • trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes.html

    r138838 r147453  
    5656</div>
    5757
     58<div class="container vertical-rl" style="position: absolute; left: 0px; right: 0px; width: auto">
     59    <div class="item vertical-rl" style="width: 100%" data-expected-height=100></div>
     60</div>
     61
    5862</body>
  • trunk/Source/WebCore/ChangeLog

    r147451 r147453  
     12013-04-02  Jochen Eisinger  <jochen@chromium.org>
     2
     3        When computing the percentage of the logical height, use the logical top and bottom
     4        https://bugs.webkit.org/show_bug.cgi?id=113761
     5
     6        Reviewed by Ojan Vafai.
     7
     8        Test: fast/writing-mode/percentage-height-orthogonal-writing-modes.html
     9
     10        * rendering/RenderBox.cpp:
     11        (WebCore::RenderBox::computePercentageLogicalHeight):
     12
    1132013-04-02  Andrey Lushnikov  <lushnikov@chromium.org>
    214
  • trunk/Source/WebCore/rendering/RenderBox.cpp

    r147261 r147453  
    26152615    // A positioned element that specified both top/bottom or that specifies height should be treated as though it has a height
    26162616    // explicitly specified that can be used for any percentage computations.
    2617     // FIXME: We can't just check top/bottom here.
    2618     // https://bugs.webkit.org/show_bug.cgi?id=46500
    2619     bool isOutOfFlowPositionedWithSpecifiedHeight = cb->isOutOfFlowPositioned() && (!cbstyle->logicalHeight().isAuto() || (!cbstyle->top().isAuto() && !cbstyle->bottom().isAuto()));
     2617    bool isOutOfFlowPositionedWithSpecifiedHeight = cb->isOutOfFlowPositioned() && (!cbstyle->logicalHeight().isAuto() || (!cbstyle->logicalTop().isAuto() && !cbstyle->logicalBottom().isAuto()));
    26202618
    26212619    bool includeBorderPadding = isTable();
Note: See TracChangeset for help on using the changeset viewer.