Changeset 147453 in webkit
- Timestamp:
- Apr 2, 2013 10:50:59 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r147450 r147453 1 2013-04-02 Jochen Eisinger <jochen@chromium.org> 2 3 When computing the percentage of the logical height, use the logical top and bottom 4 https://bugs.webkit.org/show_bug.cgi?id=113761 5 6 Reviewed by Ojan Vafai. 7 8 * fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt: 9 * fast/writing-mode/percentage-height-orthogonal-writing-modes.html: 10 1 11 2013-04-02 Nate Chapin <japhet@chromium.org> 2 12 -
trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt
r138838 r147453 7 7 PASS 8 8 PASS 9 PASS -
trunk/LayoutTests/fast/writing-mode/percentage-height-orthogonal-writing-modes.html
r138838 r147453 56 56 </div> 57 57 58 <div class="container vertical-rl" style="position: absolute; left: 0px; right: 0px; width: auto"> 59 <div class="item vertical-rl" style="width: 100%" data-expected-height=100></div> 60 </div> 61 58 62 </body> -
trunk/Source/WebCore/ChangeLog
r147451 r147453 1 2013-04-02 Jochen Eisinger <jochen@chromium.org> 2 3 When computing the percentage of the logical height, use the logical top and bottom 4 https://bugs.webkit.org/show_bug.cgi?id=113761 5 6 Reviewed by Ojan Vafai. 7 8 Test: fast/writing-mode/percentage-height-orthogonal-writing-modes.html 9 10 * rendering/RenderBox.cpp: 11 (WebCore::RenderBox::computePercentageLogicalHeight): 12 1 13 2013-04-02 Andrey Lushnikov <lushnikov@chromium.org> 2 14 -
trunk/Source/WebCore/rendering/RenderBox.cpp
r147261 r147453 2615 2615 // A positioned element that specified both top/bottom or that specifies height should be treated as though it has a height 2616 2616 // explicitly specified that can be used for any percentage computations. 2617 // FIXME: We can't just check top/bottom here. 2618 // https://bugs.webkit.org/show_bug.cgi?id=46500 2619 bool isOutOfFlowPositionedWithSpecifiedHeight = cb->isOutOfFlowPositioned() && (!cbstyle->logicalHeight().isAuto() || (!cbstyle->top().isAuto() && !cbstyle->bottom().isAuto())); 2617 bool isOutOfFlowPositionedWithSpecifiedHeight = cb->isOutOfFlowPositioned() && (!cbstyle->logicalHeight().isAuto() || (!cbstyle->logicalTop().isAuto() && !cbstyle->logicalBottom().isAuto())); 2620 2618 2621 2619 bool includeBorderPadding = isTable();
Note: See TracChangeset
for help on using the changeset viewer.