Changeset 147454 in webkit

Timestamp:

Apr 2, 2013 10:53:16 AM (11 years ago)

Author:

jochen@chromium.org

Message:

Check whether popups are allowed before creating a new window
​https://bugs.webkit.org/show_bug.cgi?id=113782

Reviewed by Adam Barth.

Source/WebCore:

Otherwise, firing a generated mouse event at an anchor is enough to
work around the popup blocker.

Test: fast/loader/url-selected-user-gesture.html

• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

LayoutTests:

• fast/loader/url-selected-user-gesture-expected.txt: Added.
• fast/loader/url-selected-user-gesture.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/loader/url-selected-user-gesture-expected.txt (added)
• LayoutTests/fast/loader/url-selected-user-gesture.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/loader/PolicyChecker.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-04-02  Jochen Eisinger  <jochen@chromium.org>
+
+        Check whether popups are allowed before creating a new window
+        https://bugs.webkit.org/show_bug.cgi?id=113782
+
+        Reviewed by Adam Barth.
+
+        * fast/loader/url-selected-user-gesture-expected.txt: Added.
+        * fast/loader/url-selected-user-gesture.html: Added.
+
 2013-04-02  Jochen Eisinger  <jochen@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-02  Jochen Eisinger  <jochen@chromium.org>
+
+        Check whether popups are allowed before creating a new window
+        https://bugs.webkit.org/show_bug.cgi?id=113782
+
+        Reviewed by Adam Barth.
+
+        Otherwise, firing a generated mouse event at an anchor is enough to
+        work around the popup blocker.
+
+        Test: fast/loader/url-selected-user-gesture.html
+
+        * loader/PolicyChecker.cpp:
+        (WebCore::PolicyChecker::checkNewWindowPolicy):
+
 2013-04-02  Jochen Eisinger  <jochen@chromium.org>
 

trunk/Source/WebCore/loader/PolicyChecker.cpp

@@ -33 +33 @@
 
 #include "ContentSecurityPolicy.h"
+#include "DOMWindow.h"
 #include "DocumentLoader.h"
 #include "FormState.h"
@@ -106 +107 @@
         return continueAfterNavigationPolicy(PolicyIgnore);
 
+    if (!DOMWindow::allowPopUp(m_frame))
+        return continueAfterNavigationPolicy(PolicyIgnore);
+
     m_callback.set(request, formState, frameName, action, function, argument);
     m_frame->loader()->client()->dispatchDecidePolicyForNewWindowAction(&PolicyChecker::continueAfterNewWindowPolicy,