Changeset 147465 in webkit


Ignore:
Timestamp:
Apr 2, 2013 11:14:14 AM (11 years ago)
Author:
yurys@chromium.org
Message:

Web Inspector: memory instrumentation for external arrays is broken
​https://bugs.webkit.org/show_bug.cgi?id=113790

Source/WebCore:

Report pointers to external arrays as retaining ones to make sure their
size is counted correctly.

Reviewed by Pavel Feldman.

Test: inspector/profiler/memory-instrumentation-external-array.html

  • inspector/InspectorMemoryAgent.cpp:

Source/WTF:

Reviewed by Pavel Feldman.

  • wtf/MemoryInstrumentationArrayBufferView.h: report buffer pointer as retaining one as

we know that the pointer is not broken.
(WTF::reportMemoryUsage):

LayoutTests:

Test that JS external resources size includes size of JS external arrays
created in the inspected page.

Reviewed by Pavel Feldman.

  • inspector/profiler/memory-instrumentation-external-array-expected.txt: Added.
  • inspector/profiler/memory-instrumentation-external-array.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
Location:
trunk
Files:
2 added
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r147463 r147465  
     12013-04-02  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Web Inspector: memory instrumentation for external arrays is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=113790
     5
     6        Test that JS external resources size includes size of JS external arrays
     7        created in the inspected page.
     8
     9        Reviewed by Pavel Feldman.
     10
     11        * inspector/profiler/memory-instrumentation-external-array-expected.txt: Added.
     12        * inspector/profiler/memory-instrumentation-external-array.html: Added.
     13        * platform/efl/TestExpectations:
     14        * platform/gtk/TestExpectations:
     15        * platform/mac/TestExpectations:
     16        * platform/qt/TestExpectations:
     17        * platform/win/TestExpectations:
     18
    1192013-04-02  Bem Jones-Bey  <bjonesbe@adobe.com>
    220

  • trunk/LayoutTests/platform/efl/TestExpectations

    r147430 r147465  
    14421442webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
    14431443
     1444webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
     1445
    14441446# ENABLE(INPUT_MULTIPLE_FIELDS_UI) is disabled
    14451447fast/forms/date-multiple-fields

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r147430 r147465  
    945945webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
    946946
     947webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
    947948webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html [ Failure ]
    948949

  • trunk/LayoutTests/platform/mac/TestExpectations

    r147445 r147465  
    287287inspector/profiler/heap-snapshot-summary-sorting-instances.html
    288288webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
     289
     290webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
    289291
    290292# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms

  • trunk/LayoutTests/platform/qt/TestExpectations

    r147430 r147465  
    272272inspector/profiler/memory-instrumentation-cached-images.html
    273273webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
     274
     275webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
    274276
    275277# https://bugs.webkit.org/show_bug.cgi?id=40300

  • trunk/LayoutTests/platform/win/TestExpectations

    r147365 r147465  
    13081308inspector/profiler/heap-snapshot-summary-sorting-instances.html
    13091309webkit.org/b/50485 inspector-protocol/heap-profiler [ Skip ]
     1310
     1311webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
    13101312
    13111313# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms

  • trunk/Source/WTF/ChangeLog

    r147345 r147465  
     12013-04-02  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Web Inspector: memory instrumentation for external arrays is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=113790
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * wtf/MemoryInstrumentationArrayBufferView.h: report buffer pointer as retaining one as
     9        we know that the pointer is not broken.
     10        (WTF::reportMemoryUsage):
     11
    1122013-04-01  Han Shen  <shenhan@google.com>
    213

  • trunk/Source/WTF/wtf/MemoryInstrumentationArrayBufferView.h

    r141591 r147465  
    4040{
    4141    MemoryClassInfo info(memoryObjectInfo, arrayBufferView);
    42     info.addMember(arrayBufferView->buffer().get(), "buffer");
     42    info.addMember(arrayBufferView->buffer().get(), "buffer", RetainingPointer);
    4343}
    4444

  • trunk/Source/WebCore/ChangeLog

    r147464 r147465  
     12013-04-02  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Web Inspector: memory instrumentation for external arrays is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=113790
     5
     6        Report pointers to external arrays as retaining ones to make sure their
     7        size is counted correctly.
     8
     9        Reviewed by Pavel Feldman.
     10
     11        Test: inspector/profiler/memory-instrumentation-external-array.html
     12
     13        * inspector/InspectorMemoryAgent.cpp:
     14
    1152013-04-02  Peter Beverloo  <peter@chromium.org>
    216

  • trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp

    r143218 r147465  
    183183    virtual void visitJSExternalArray(ArrayBufferView* arrayBufferView)
    184184    {
    185         m_memoryClassInfo->addMember(arrayBufferView, "externalArray");
     185        m_memoryClassInfo->addMember(arrayBufferView, "externalArray", WTF::RetainingPointer);
    186186    }
    187187
Note: See TracChangeset for help on using the changeset viewer.