Changeset 147490 in webkit

Timestamp:

Apr 2, 2013 1:04:00 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GStreamer] Memory leaks in MediaPlayerPrivateGStreamer
​https://bugs.webkit.org/show_bug.cgi?id=113762

Patch by Sudarsana Nagineni <​sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Philippe Normand.

Don't leak strings returned by gst_element_get_name() and
gst_missing_plugin_message_get_installer_detail().

No new tests. No change in behavior.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
+
+        [GStreamer] Memory leaks in MediaPlayerPrivateGStreamer
+        https://bugs.webkit.org/show_bug.cgi?id=113762
+
+        Reviewed by Philippe Normand.
+
+        Don't leak strings returned by gst_element_get_name() and
+        gst_missing_plugin_message_get_installer_detail().
+
+        No new tests. No change in behavior.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
+        (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
+
 2013-04-02  Min Qin  <qinmin@chromium.org>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -149 +149 @@
     g_object_set(object, "stream-properties", structure, NULL);
     gst_structure_free(structure);
-    LOG_MEDIA_MESSAGE("Set media.role as %s at %s", role, gst_element_get_name(GST_ELEMENT(object)));
+    GOwnPtr<gchar> elementName(gst_element_get_name(GST_ELEMENT(object)));
+    LOG_MEDIA_MESSAGE("Set media.role as %s at %s", role, elementName.get());
 }
 
@@ -770 +771 @@
         gst_element_get_state(m_playBin.get(), &currentState, NULL, 250);
         if (requestedState < currentState) {
-            LOG_MEDIA_MESSAGE("Element %s requested state change to %s", gst_element_get_name(GST_MESSAGE_SRC(message)),
+            GOwnPtr<gchar> elementName(gst_element_get_name(GST_ELEMENT(message)));
+            LOG_MEDIA_MESSAGE("Element %s requested state change to %s", elementName.get(),
                 gst_element_state_get_name(requestedState));
             m_requestedState = requestedState;
@@ -778 +780 @@
     case GST_MESSAGE_ELEMENT:
         if (gst_is_missing_plugin_message(message)) {
-            char* detail = gst_missing_plugin_message_get_installer_detail(message);
+            gchar* detail = gst_missing_plugin_message_get_installer_detail(message);
             GstInstallPluginsReturn result = gst_install_plugins_async(&detail, 0, mediaPlayerPrivatePluginInstallerResultFunction, this);
             m_missingPlugins = result == GST_INSTALL_PLUGINS_STARTED_OK;
+            g_free(detail);
         }
         break;