Changeset 147548 in webkit
- Timestamp:
- Apr 3, 2013 6:20:29 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 11 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r147538 r147548 1 2013-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.com> 2 3 Should close select popup when the element loses focus 4 https://bugs.webkit.org/show_bug.cgi?id=113220 5 6 Reviewed by Kent Tamura. 7 8 * fast/forms/select/popup-closes-on-blur-expected.txt: Added. 9 * fast/forms/select/popup-closes-on-blur.html: Added. 10 * platform/mac/TestExpectations: 11 * platform/win/TestExpectations: 12 1 13 2013-04-03 Antoine Quint <graouts@apple.com> 2 14 -
trunk/LayoutTests/platform/mac/TestExpectations
r147522 r147548 186 186 # Color input is not yet enabled. 187 187 fast/forms/color 188 189 # Times out only in non-wk2 Mac, possibly because of platform-specific behaviour 190 # interfering with how the test is executed. 191 # https://bugs.webkit.org/show_bug.cgi?id=113220 192 fast/forms/select/popup-closes-on-blur.html [ Timeout Pass ] 188 193 189 194 # ENABLE_INPUT_TYPE_* are not enabled. -
trunk/LayoutTests/platform/win/TestExpectations
r147522 r147548 208 208 fast/events/option-tab.html 209 209 fast/forms/focus2.html 210 211 # Unidentified crash, possibly related to linking issues? 212 # https://bugs.webkit.org/show_bug.cgi?id=113220 213 fast/forms/select/popup-closes-on-blur.html [ Crash ] 210 214 211 215 # fast/html/keygen.html is failing on boomer <rdar://problem/5133799> -
trunk/Source/WebCore/ChangeLog
r147545 r147548 1 2013-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.com> 2 3 Should close select popup when the element loses focus 4 https://bugs.webkit.org/show_bug.cgi?id=113220 5 6 Reviewed by Kent Tamura. 7 8 Test: fast/forms/select-popup-closes-on-blur.html 9 10 * html/HTMLSelectElement.cpp: 11 (WebCore::HTMLSelectElement::menuListDefaultEventHandler): handle the blur event, closing 12 the popup menu if any. 13 * testing/Internals.cpp: 14 (WebCore::Internals::isSelectPopupVisible): utility to query the select node renderer to 15 find out whether the popup is open or closed. 16 (WebCore): 17 * testing/Internals.h: add the new method definition. 18 * testing/Internals.idl: ditto. 19 1 20 2013-03-28 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 2 21 -
trunk/Source/WebCore/html/HTMLSelectElement.cpp
r147205 r147548 1225 1225 } 1226 1226 event->setDefaultHandled(); 1227 } 1228 1229 if (event->type() == eventNames().blurEvent) { 1230 if (RenderMenuList* menuList = toRenderMenuList(renderer())) { 1231 if (menuList->popupIsVisible()) 1232 menuList->hidePopup(); 1233 } 1227 1234 } 1228 1235 } -
trunk/Source/WebCore/testing/Internals.cpp
r147039 r147548 56 56 #endif 57 57 #include "HTMLNames.h" 58 #include "HTMLSelectElement.h" 58 59 #include "HTMLTextAreaElement.h" 59 60 #include "HistoryItem.h" … … 78 79 #include "PseudoElement.h" 79 80 #include "Range.h" 81 #include "RenderMenuList.h" 80 82 #include "RenderObject.h" 81 83 #include "RenderTreeAsText.h" … … 2103 2105 #endif 2104 2106 2105 } 2107 bool Internals::isSelectPopupVisible(Node* node) 2108 { 2109 if (!isHTMLSelectElement(node)) 2110 return false; 2111 2112 HTMLSelectElement* select = toHTMLSelectElement(node); 2113 2114 RenderObject* renderer = select->renderer(); 2115 if (!renderer->isMenuList()) 2116 return false; 2117 2118 RenderMenuList* menuList = toRenderMenuList(renderer); 2119 return menuList->popupIsVisible(); 2120 } 2121 2122 } -
trunk/Source/WebCore/testing/Internals.h
r147039 r147548 310 310 #endif 311 311 312 bool isSelectPopupVisible(Node*); 313 312 314 private: 313 315 explicit Internals(Document*); -
trunk/Source/WebCore/testing/Internals.idl
r147039 r147548 272 272 273 273 DOMString getImageSourceURL(in Element element) raises(DOMException); 274 275 boolean isSelectPopupVisible(in Node node); 274 276 }; -
trunk/Source/WebKit/win/ChangeLog
r147482 r147548 1 2013-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.com> 2 3 Should close select popup when the element loses focus 4 https://bugs.webkit.org/show_bug.cgi?id=113220 5 6 Reviewed by Kent Tamura. 7 8 * WebKit.vcproj/WebKitExports.def.in: export WebCore::HTMLNames::selectTag for Internals 9 1 10 2013-04-02 Timothy Hatcher <timothy@apple.com> 2 11 -
trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in
r147046 r147548 197 197 ?getReferencedFilePaths@FormController@WebCore@@SA?AV?$Vector@VString@WTF@@$0A@@WTF@@ABV34@@Z 198 198 ?inputTag@HTMLNames@WebCore@@3VQualifiedName@2@B 199 ?selectTag@HTMLNames@WebCore@@3VQualifiedName@2@B 199 200 #if ENABLE(INSPECTOR) 200 201 ?getHighlight@InspectorController@WebCore@@QBEXPAUHighlight@2@@Z -
trunk/Source/autotools/symbols.filter
r147085 r147548 52 52 _ZN7WebCore8toUInt64EPN3JSC9ExecStateENS0_7JSValueENS_30IntegerConversionConfigurationE; 53 53 _ZN7WebCore9HTMLNames8inputTagE; 54 _ZN7WebCore9HTMLNames9selectTagE; 54 55 _ZN7WebCore9HTMLNames11textareaTagE; 55 56 _ZN7WebCore10JSDocument10putVirtualEPN3JSC9ExecStateERKNS1_10IdentifierENS1_7JSValueERNS1_15PutPropertySlotE;
Note: See TracChangeset
for help on using the changeset viewer.