Changeset 147577 in webkit

Timestamp:

Apr 3, 2013 12:53:55 PM (11 years ago)

Author:

mvujovic@adobe.com

Message:

Compositing tests failing after ​http://trac.webkit.org/changeset/147502
​https://bugs.webkit.org/show_bug.cgi?id=113838

Reviewed by Dean Jackson.

Add (contentsOpaque 1) to the DRT text output in some expectations files due to bug 70634
"Mark GraphicsLayers as opaque when possible" [1]. The expectations in the guilty changeset
weren't updated after bug 70634 landed.

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=70634

• compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
• compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
• compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt (modified) (1 diff)
• compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt (modified) (1 diff)
• compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-04-03  Max Vujovic  <mvujovic@adobe.com>
+
+        Compositing tests failing after http://trac.webkit.org/changeset/147502
+        https://bugs.webkit.org/show_bug.cgi?id=113838
+
+        Reviewed by Dean Jackson.
+
+        Add (contentsOpaque 1) to the DRT text output in some expectations files due to bug 70634
+        "Mark GraphicsLayers as opaque when possible" [1]. The expectations in the guilty changeset
+        weren't updated after bug 70634 landed.
+
+        [1]: https://bugs.webkit.org/show_bug.cgi?id=70634
+
+        * compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
+        * compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
+        * compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
+        * platform/mac/TestExpectations:
+
 2013-04-02  Mark Hahnenberg  <mhahnenberg@apple.com>
 

trunk/LayoutTests/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt

@@ -9 +9 @@
           (position 105.00 105.00)
           (bounds 100.00 100.00)
+          (contentsOpaque 1)
           (drawsContent 1)
         )

trunk/LayoutTests/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt

@@ -13 +13 @@
         (GraphicsLayer
           (bounds 100.00 100.00)
+          (contentsOpaque 1)
           (drawsContent 1)
         )

trunk/LayoutTests/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt

@@ -9 +9 @@
           (position 130.00 130.00)
           (bounds 100.00 100.00)
+          (contentsOpaque 1)
           (drawsContent 1)
         )
         (GraphicsLayer
           (bounds 100.00 100.00)
+          (contentsOpaque 1)
           (drawsContent 1)
         )

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1506 +1506 @@
 webkit.org/b/113227 transitions/svg-text-shadow-transition.html [ Pass Failure ]
 
-webkit.org/b/113838 compositing/filters/sw-layer-overlaps-hw-shadow.html [ Pass Failure ]
-webkit.org/b/113838 compositing/filters/sw-shadow-overlaps-hw-layer.html [ Pass Failure ]
-webkit.org/b/113838 compositing/filters/sw-shadow-overlaps-hw-shadow.html [ Pass Failure ]
-