Changeset 147600 in webkit

Timestamp:

Apr 3, 2013 6:02:57 PM (11 years ago)

Author:

shawnsingh@chromium.org

Message:

Add comment to clarify isStackingContext() in RenderLayer.h
​https://bugs.webkit.org/show_bug.cgi?id=113909

Reviewed by Simon Fraser.

It was not obvious how the implementation of isStackingContext()
was correct, a comment is appropriate here for anyone who reads
this code in the future.

Just a change in comment, no test needed.

• rendering/RenderLayer.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayer.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-03  Shawn Singh  <shawnsingh@chromium.org>
+
+        Add comment to clarify isStackingContext() in RenderLayer.h
+        https://bugs.webkit.org/show_bug.cgi?id=113909
+
+        Reviewed by Simon Fraser.
+
+        It was not obvious how the implementation of isStackingContext()
+        was correct, a comment is appropriate here for anyone who reads
+        this code in the future.
+
+        Just a change in comment, no test needed.
+
+        * rendering/RenderLayer.h:
+
 2013-04-03  Hans Muller  <hmuller@adobe.com>
 

trunk/Source/WebCore/rendering/RenderLayer.h

@@ -865 +865 @@
     void updateNormalFlowList();
 
+    // Non-auto z-index always implies stacking context here, because StyleResolver::adjustRenderStyle already adjusts z-index
+    // based on positioning and other criteria.
     bool isStackingContext(const RenderStyle* style) const { return !style->hasAutoZIndex() || isRootLayer(); }