Changeset 147709 in webkit

Timestamp:

Apr 4, 2013 10:36:52 PM (11 years ago)

Author:

benjamin@webkit.org

Message:

Temporarily disable the Python unittests broken by the commit queue not running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=113997

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-04
Reviewed by Ryosuke Niwa.

Disable the tests until Ryosuke gets the time and hardware to have
a testing commit-queue.

• Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(CommitQueueTaskTest):

• Scripts/webkitpy/tool/commands/queues_unittest.py:

(CommitQueueTest):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py (modified) (9 diffs)
• Scripts/webkitpy/tool/commands/queues_unittest.py (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
+
+        Temporarily disable the Python unittests broken by the commit queue not running layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=113997
+
+        Reviewed by Ryosuke Niwa.
+
+        Disable the tests until Ryosuke gets the time and hardware to have
+        a testing commit-queue.
+
+        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
+        (CommitQueueTaskTest):
+        * Scripts/webkitpy/tool/commands/queues_unittest.py:
+        (CommitQueueTest):
+
 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py

@@ -133 +133 @@
         return task
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_success_case(self):
         commit_queue = MockCommitQueue([])
@@ -271 +272 @@
         self._run_through_task(commit_queue, expected_logs, expect_retry=True)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_flaky_test_failure(self):
         commit_queue = MockCommitQueue([
@@ -304 +306 @@
         self._run_through_task(commit_queue, expected_logs)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_failed_archive(self):
         commit_queue = MockCommitQueue([
@@ -336 +339 @@
         self._run_through_task(commit_queue, expected_logs)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_double_flaky_test_failure(self):
         commit_queue = FailingTestCommitQueue([
@@ -375 +379 @@
         self.assertFalse(success)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_test_failure(self):
         commit_queue = MockCommitQueue([
@@ -406 +411 @@
         self._run_through_task(commit_queue, expected_logs, GoldenScriptError)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_red_test_failure(self):
         commit_queue = FailingTestCommitQueue([
@@ -447 +453 @@
         self._run_through_task(commit_queue, expected_logs)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_very_red_tree_retry(self):
         lots_of_failing_tests = map(lambda num: "test-%s.html" % num, range(0, 100))
@@ -488 +495 @@
         self._run_through_task(commit_queue, expected_logs, expect_retry=True)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_red_tree_patch_rejection(self):
         commit_queue = FailingTestCommitQueue([
@@ -530 +538 @@
         self.assertEqual(task.failure_status_id, 1)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_land_failure(self):
         commit_queue = MockCommitQueue([

trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py

@@ -29 +29 @@
 import os
 import StringIO
+import unittest
 
 from webkitpy.common.checkout.scm import CheckoutNeedsUpdate
@@ -233 +234 @@
         return test_results.TestResult(testname, [test_failures.FailureTextMismatch()])
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_commit_queue(self):
         tool = MockTool()
@@ -316 +318 @@
         self.assert_queue_outputs(queue, expected_logs=expected_logs)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_rollout(self):
         tool = MockTool()
@@ -387 +390 @@
         self.assertFalse(options.test)
 
+    @unittest.skip("Commit queue testing temporarily disabled.")
     def test_manual_reject_during_processing(self):
         queue = SecondThoughtsCommitQueue(MockTool())