Changeset 147719 in webkit

Timestamp:

Apr 5, 2013 12:48:24 AM (11 years ago)

Author:

rniwa@webkit.org

Message:

Remove Chromium code from Source/WebCore/dom
​https://bugs.webkit.org/show_bug.cgi?id=114007

Reviewed by Benjamin Poulain.

Removed.

• dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::implicitClose):
(WebCore::Document::setFocusedNode):

• dom/MessagePortChannel.h:

(MessagePortChannel):

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

• dom/default/chromium: Removed.
• dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Removed.
• dom/default/chromium/PlatformMessagePortChannelChromium.h: Removed.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (4 diffs)
• dom/MessagePortChannel.h (modified) (1 diff)
• dom/ShadowRoot.cpp (modified) (1 diff)
• dom/default/chromium (deleted)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Remove Chromium code from Source/WebCore/dom
+        https://bugs.webkit.org/show_bug.cgi?id=114007
+
+        Reviewed by Benjamin Poulain.
+
+        Removed.
+
+        * dom/Document.cpp:
+        (WebCore::Document::recalcStyle):
+        (WebCore::Document::implicitClose):
+        (WebCore::Document::setFocusedNode):
+        * dom/MessagePortChannel.h:
+        (MessagePortChannel):
+        * dom/ShadowRoot.cpp:
+        (WebCore::ShadowRoot::ShadowRoot):
+        * dom/default/chromium: Removed.
+        * dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Removed.
+        * dom/default/chromium/PlatformMessagePortChannelChromium.h: Removed.
+
 2013-04-05  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -246 +246 @@
 #endif
 
-#if PLATFORM(CHROMIUM)
-#include "TraceEvent.h"
-#endif
-
 #if ENABLE(VIDEO_TRACK)
 #include "CaptionUserPreferences.h"
@@ -1824 +1820 @@
         return; // Guard against re-entrancy. -dwh
 
-#if PLATFORM(CHROMIUM)
-    TRACE_EVENT0("webkit", "Document::recalcStyle");
-#endif
-
     // FIXME: We should update style on our ancestor chain before proceeding (especially for seamless),
     // however doing so currently causes several tests to crash, as Frame::setDocument calls Document::attach
@@ -2529 +2521 @@
     m_processingLoadEvent = false;
 
-#if PLATFORM(MAC) || PLATFORM(CHROMIUM)
+#if PLATFORM(MAC)
     if (f && renderObject && AXObjectCache::accessibilityEnabled()) {
         // The AX cache may have been cleared at this point, but we need to make sure it contains an
@@ -3498 +3490 @@
     }
 
-    if (!focusChangeBlocked && m_focusedNode) {
-        // Create the AXObject cache in a focus change because Chromium relies on it.
-        if (AXObjectCache* cache = axObjectCache())
-            cache->handleFocusedUIElementChanged(oldFocusedNode.get(), newFocusedNode.get());
-    }
-
     if (!focusChangeBlocked)
         page()->chrome()->focusedNodeChanged(m_focusedNode.get());

trunk/Source/WebCore/dom/MessagePortChannel.h

@@ -86 +86 @@
         ~MessagePortChannel();
 
-#if PLATFORM(CHROMIUM)
-        // Creates a new wrapper for the passed channel.
-        static PassOwnPtr<MessagePortChannel> create(PassRefPtr<PlatformMessagePortChannel>);
-
-        // FIXME: PlatformMessagePortChannel is an implementation detail, and should not be exposed via a public function.
-        PlatformMessagePortChannel* channel() const { return m_channel.get(); }
-#endif
-
     private:
         explicit MessagePortChannel(PassRefPtr<PlatformMessagePortChannel>);

trunk/Source/WebCore/dom/ShadowRoot.cpp

@@ -64 +64 @@
 {
     ASSERT(document);
-
-#if PLATFORM(CHROMIUM)
-    if (type == ShadowRoot::AuthorShadowRoot) {
-        ShadowRootUsageOriginType usageType = document->url().protocolIsInHTTPFamily() ? ShadowRootUsageOriginWeb : ShadowRootUsageOriginNotWeb;
-        HistogramSupport::histogramEnumeration("WebCore.ShadowRoot.constructor", usageType, ShadowRootUsageOriginMax);
-    }
-#endif
 }