Changeset 147736 in webkit


Ignore:
Timestamp:
Apr 5, 2013 4:01:21 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
​https://bugs.webkit.org/show_bug.cgi?id=114009

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.

These methods were removed in r133517 but were accidentally
introduced again in r145968.
The previous patch didn't remove them all.

  • WebKitSupport/DefaultTapHighlight.cpp:
  • WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

  • WebKitSupport/InspectorOverlayBlackBerry.cpp:
  • WebKitSupport/InspectorOverlayBlackBerry.h:

(InspectorOverlay):

  • WebKitSupport/SelectionOverlay.cpp:
  • WebKitSupport/SelectionOverlay.h:

(SelectionOverlay):

Location:
trunk/Source/WebKit/blackberry
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/blackberry/ChangeLog

    r147728 r147736  
     12013-04-05  Alberto Garcia  <agarcia@igalia.com>
     2
     3        [BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
     4        https://bugs.webkit.org/show_bug.cgi?id=114009
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        These methods were removed in r133517 but were accidentally
     9        introduced again in r145968.
     10        The previous patch didn't remove them all.
     11
     12        * WebKitSupport/DefaultTapHighlight.cpp:
     13        * WebKitSupport/DefaultTapHighlight.h:
     14        (DefaultTapHighlight):
     15        * WebKitSupport/InspectorOverlayBlackBerry.cpp:
     16        * WebKitSupport/InspectorOverlayBlackBerry.h:
     17        (InspectorOverlay):
     18        * WebKitSupport/SelectionOverlay.cpp:
     19        * WebKitSupport/SelectionOverlay.h:
     20        (SelectionOverlay):
     21
    1222013-04-05  Alberto Garcia  <agarcia@igalia.com>
    223

  • trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp

    r147386 r147736  
    148148}
    149149
    150 bool DefaultTapHighlight::showDebugBorders(const GraphicsLayer* layer) const
    151 {
    152     return m_page->showDebugBorders(layer);
    153 }
    154 
    155 bool DefaultTapHighlight::showRepaintCounter(const GraphicsLayer* layer) const
    156 {
    157     return m_page->showRepaintCounter(layer);
    158 }
    159 
    160150} // namespace WebKit
    161151} // namespace BlackBerry

  • trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h

    r145968 r147736  
    5858    virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
    5959    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
    60     virtual bool showDebugBorders(const WebCore::GraphicsLayer*) const;
    61     virtual bool showRepaintCounter(const WebCore::GraphicsLayer*) const;
    6260
    6361private:

  • trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.cpp

    r145968 r147736  
    5757}
    5858
    59 bool InspectorOverlay::showDebugBorders(const WebCore::GraphicsLayer* layer) const
    60 {
    61     return m_webPage->showDebugBorders(layer);
    62 }
    63 
    64 bool InspectorOverlay::showRepaintCounter(const WebCore::GraphicsLayer* layer) const
    65 {
    66     return m_webPage->showRepaintCounter(layer);
    67 }
    6859#endif
    6960

  • trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.h

    r145968 r147736  
    5555    virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
    5656    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
    57     virtual bool showDebugBorders(const WebCore::GraphicsLayer*) const;
    58     virtual bool showRepaintCounter(const WebCore::GraphicsLayer*) const;
    5957#endif
    6058

  • trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.cpp

    r146627 r147736  
    122122}
    123123
    124 bool SelectionOverlay::showDebugBorders(const GraphicsLayer* layer) const
    125 {
    126     return m_page->showDebugBorders(layer);
    127 }
    128 
    129 bool SelectionOverlay::showRepaintCounter(const GraphicsLayer* layer) const
    130 {
    131     return m_page->showRepaintCounter(layer);
    132 }
    133 
    134124} // namespace WebKit
    135125} // namespace BlackBerry

  • trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.h

    r145968 r147736  
    5858    virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
    5959    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
    60     virtual bool showDebugBorders(const WebCore::GraphicsLayer*) const;
    61     virtual bool showRepaintCounter(const WebCore::GraphicsLayer*) const;
    6260
    6361private:
Note: See TracChangeset for help on using the changeset viewer.