Changeset 147740 in webkit


Ignore:
Timestamp:
Apr 5, 2013 5:50:46 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
​https://bugs.webkit.org/show_bug.cgi?id=114022

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.

Naming the 'time' and 'inClip' unused parameters only produces
compiler warnings.

  • Api/WebOverlay_p.h:

(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
(WebOverlayPrivateWebKitThread):

  • Api/WebPage_p.h:

(BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
(BlackBerry::WebKit::WebPagePrivate::paintContents):

  • WebKitSupport/DefaultTapHighlight.h:

(BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):

  • WebKitSupport/InspectorOverlayBlackBerry.cpp:

(BlackBerry::WebKit::InspectorOverlay::paintContents):

  • WebKitSupport/InspectorOverlayBlackBerry.h:

(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
(InspectorOverlay):

  • WebKitSupport/SelectionOverlay.h:

(BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):

Location:
trunk/Source/WebKit/blackberry
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/blackberry/Api/WebOverlay_p.h

    r147728 r147740  
    167167
    168168    // GraphicsLayerClient
    169     virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
     169    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
    170170    virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
    171     virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
     171    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
    172172
    173173private:

  • trunk/Source/WebKit/blackberry/Api/WebPage_p.h

    r147537 r147740  
    402402
    403403    // Fallback GraphicsLayerClient implementation, used for various overlay layers.
    404     virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
     404    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
    405405    virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
    406     virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip) { }
     406    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&) { }
    407407
    408408    // WebKit thread, plumbed through from ChromeClientBlackBerry.

  • trunk/Source/WebKit/blackberry/ChangeLog

    r147738 r147740  
     12013-04-05  Alberto Garcia  <agarcia@igalia.com>
     2
     3        [BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
     4        https://bugs.webkit.org/show_bug.cgi?id=114022
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        Naming the 'time' and 'inClip' unused parameters only produces
     9        compiler warnings.
     10
     11        * Api/WebOverlay_p.h:
     12        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
     13        (WebOverlayPrivateWebKitThread):
     14        * Api/WebPage_p.h:
     15        (BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
     16        (BlackBerry::WebKit::WebPagePrivate::paintContents):
     17        * WebKitSupport/DefaultTapHighlight.h:
     18        (BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
     19        * WebKitSupport/InspectorOverlayBlackBerry.cpp:
     20        (BlackBerry::WebKit::InspectorOverlay::paintContents):
     21        * WebKitSupport/InspectorOverlayBlackBerry.h:
     22        (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
     23        (InspectorOverlay):
     24        * WebKitSupport/SelectionOverlay.h:
     25        (BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
     26
    1272013-04-05  Alberto Garcia  <agarcia@igalia.com>
    228

  • trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h

    r147736 r147740  
    5555
    5656    // GraphicsLayerClient
    57     virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
     57    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
    5858    virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
    5959    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);

  • trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.cpp

    r147736 r147740  
    4848}
    4949
    50 void InspectorOverlay::paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext& context, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip)
     50void InspectorOverlay::paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext& context, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&)
    5151{
    5252    context.save();

  • trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlayBlackBerry.h

    r147736 r147740  
    5252
    5353#if USE(ACCELERATED_COMPOSITING)
    54     virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
     54    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
    5555    virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
    56     virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
     56    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
    5757#endif
    5858

  • trunk/Source/WebKit/blackberry/WebKitSupport/SelectionOverlay.h

    r147736 r147740  
    5555
    5656    // GraphicsLayerClient
    57     virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
     57    virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
    5858    virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
    5959    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
Note: See TracChangeset for help on using the changeset viewer.