Changeset 147743 in webkit

Timestamp:

Apr 5, 2013 6:42:35 AM (11 years ago)

Author:

rakuco@webkit.org

Message:

[EFL] Disable GLOBAL_FAST_MALLOC_NEW by default.
​https://bugs.webkit.org/show_bug.cgi?id=114031

Reviewed by Alexis Menard.

Follow what some other ports already do and avoid globally overriding
the new' and delete' operators with the ones in FastMalloc.

In many cases, third-party or client code allocates memory with
standard library calls but the memory gets deleted by FastMalloc,
causing a crash. The reverse (ie. memory being allocated by FastMalloc
and freed by the system libraries) is also possible.

Commits 135666 and 121018 provide more information about this, as well
as comment 6 in bug 89358.

• wtf/Platform.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Platform.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
+
+        [EFL] Disable GLOBAL_FAST_MALLOC_NEW by default.
+        https://bugs.webkit.org/show_bug.cgi?id=114031
+
+        Reviewed by Alexis Menard.
+
+        Follow what some other ports already do and avoid globally overriding
+        the `new' and `delete' operators with the ones in FastMalloc.
+
+        In many cases, third-party or client code allocates memory with
+        standard library calls but the memory gets deleted by FastMalloc,
+        causing a crash. The reverse (ie. memory being allocated by FastMalloc
+        and freed by the system libraries) is also possible.
+
+        Commits 135666 and 121018 provide more information about this, as well
+        as comment 6 in bug 89358.
+
+        * wtf/Platform.h:
+
 2013-04-05  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WTF/wtf/Platform.h

@@ -710 +710 @@
 #endif
 
+#if PLATFORM(EFL)
+#define ENABLE_GLOBAL_FASTMALLOC_NEW 0
+#endif
+
 #if !defined(ENABLE_GLOBAL_FASTMALLOC_NEW)
 #define ENABLE_GLOBAL_FASTMALLOC_NEW 1