Changeset 147791 in webkit

Timestamp:

Apr 5, 2013 1:04:25 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

Unreviewed, rolling out r147773 and r147774.
​http://trac.webkit.org/changeset/147773
​http://trac.webkit.org/changeset/147774
​https://bugs.webkit.org/show_bug.cgi?id=114056

Causing some exceptions on AppEngine I don't understand
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-04-05

• QueueStatusServer/config/queues.py:
• QueueStatusServer/model/queues.py:

(Queue.short_name):
(Queue.display_name):

• QueueStatusServer/model/queues_unittest.py:

(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/config/queues.py (modified) (1 diff)
• QueueStatusServer/model/queues.py (modified) (2 diffs)
• QueueStatusServer/model/queues_unittest.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r147773 and r147774.
+        http://trac.webkit.org/changeset/147773
+        http://trac.webkit.org/changeset/147774
+        https://bugs.webkit.org/show_bug.cgi?id=114056
+
+        Causing some exceptions on AppEngine I don't understand
+        (Requested by rniwa on #webkit).
+
+        * QueueStatusServer/config/queues.py:
+        * QueueStatusServer/model/queues.py:
+        (Queue.short_name):
+        (Queue.display_name):
+        * QueueStatusServer/model/queues_unittest.py:
+        (QueueTest.test_short_name):
+        (QueueTest.test_display_name):
+        (QueueTest.test_name_with_underscores):
+
 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Tools/QueueStatusServer/config/queues.py

@@ -31 +31 @@
     "commit-queue",
     "style-queue",
+    "chromium-ews",  # aka cr-linux-ews
+    "cr-linux-debug-ews",
+    "cr-android-ews",
     "qt-ews",
     "qt-wk2-ews",

trunk/Tools/QueueStatusServer/model/queues.py

@@ -70 +70 @@
     def short_name(self):
         # HACK: chromium-ews is incorrectly named.
-        short_name = self._name.replace("-ews", "")
+        short_name = self._name.replace("chromium-ews", "Cr-Linux-ews")
+        short_name = short_name.replace("-ews", "")
         short_name = short_name.replace("-queue", "")
         return self._caplitalize_after_dash(short_name.capitalize())
@@ -76 +77 @@
     def display_name(self):
         # HACK: chromium-ews is incorrectly named.
-        display_name = self._name.replace("-", " ")
+        display_name = self._name.replace("chromium-ews", "cr-linux-ews")
+
+        display_name = display_name.replace("-", " ")
+        display_name = display_name.replace("cr", "chromium")
         display_name = display_name.title()
         display_name = display_name.replace("Ews", "EWS")

trunk/Tools/QueueStatusServer/model/queues_unittest.py

@@ -48 +48 @@
     def test_short_name(self):
         self._assert_short_name("mac-ews", "Mac")
+        self._assert_short_name("chromium-ews", "Cr-Linux")
         self._assert_short_name("commit-queue", "Commit")
         self._assert_short_name("style-queue", "Style")
@@ -56 +57 @@
     def test_display_name(self):
         self._assert_display_name("mac-ews", "Mac EWS")
+        self._assert_display_name("chromium-ews", "Chromium Linux EWS")
         self._assert_display_name("commit-queue", "Commit Queue")
         self._assert_display_name("style-queue", "Style Queue")
@@ -64 +66 @@
     def test_name_with_underscores(self):
         self._assert_name_with_underscores("mac-ews", "mac_ews")
+        self._assert_name_with_underscores("chromium-ews", "chromium_ews")
         self._assert_name_with_underscores("commit-queue", "commit_queue")