Changeset 147826 in webkit
- Timestamp:
- Apr 5, 2013 7:05:18 PM (11 years ago)
- Location:
- trunk/Tools
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r147818 r147826 1 2013-04-05 Ryosuke Niwa <rniwa@webkit.org> 2 3 Re-enable testing on the commit queue 4 https://bugs.webkit.org/show_bug.cgi?id=114078 5 6 Reviewed by Darin Adler. 7 8 Re-enabled the feature and the associated tests. 9 10 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 11 (CommitQueueTask.run): 12 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 13 (CommitQueueTaskTest._run_through_task): 14 * Scripts/webkitpy/tool/commands/queues_unittest.py: 15 (CommitQueueTest._mock_test_result): 16 1 17 2013-04-05 Oliver Hunt <oliver@apple.com> 2 18 -
trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py
r147695 r147826 83 83 return False 84 84 return self.report_failure() 85 # FIXME: We temporarily disable tests on commit queue as we don't have enough machine resources. 86 # if not self._did_pass_tests_recently(): 87 # return False 85 if not self._did_pass_tests_recently(): 86 return False 88 87 # Make sure the patch is still valid before landing (e.g., make sure 89 88 # no one has set commit-queue- since we started working on the patch.) -
trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
r147709 r147826 133 133 return task 134 134 135 @unittest.skip("Commit queue testing temporarily disabled.")136 135 def test_success_case(self): 137 136 commit_queue = MockCommitQueue([]) … … 272 271 self._run_through_task(commit_queue, expected_logs, expect_retry=True) 273 272 274 @unittest.skip("Commit queue testing temporarily disabled.")275 273 def test_flaky_test_failure(self): 276 274 commit_queue = MockCommitQueue([ … … 306 304 self._run_through_task(commit_queue, expected_logs) 307 305 308 @unittest.skip("Commit queue testing temporarily disabled.")309 306 def test_failed_archive(self): 310 307 commit_queue = MockCommitQueue([ … … 339 336 self._run_through_task(commit_queue, expected_logs) 340 337 341 @unittest.skip("Commit queue testing temporarily disabled.")342 338 def test_double_flaky_test_failure(self): 343 339 commit_queue = FailingTestCommitQueue([ … … 379 375 self.assertFalse(success) 380 376 381 @unittest.skip("Commit queue testing temporarily disabled.")382 377 def test_test_failure(self): 383 378 commit_queue = MockCommitQueue([ … … 411 406 self._run_through_task(commit_queue, expected_logs, GoldenScriptError) 412 407 413 @unittest.skip("Commit queue testing temporarily disabled.")414 408 def test_red_test_failure(self): 415 409 commit_queue = FailingTestCommitQueue([ … … 453 447 self._run_through_task(commit_queue, expected_logs) 454 448 455 @unittest.skip("Commit queue testing temporarily disabled.")456 449 def test_very_red_tree_retry(self): 457 450 lots_of_failing_tests = map(lambda num: "test-%s.html" % num, range(0, 100)) … … 495 488 self._run_through_task(commit_queue, expected_logs, expect_retry=True) 496 489 497 @unittest.skip("Commit queue testing temporarily disabled.")498 490 def test_red_tree_patch_rejection(self): 499 491 commit_queue = FailingTestCommitQueue([ … … 538 530 self.assertEqual(task.failure_status_id, 1) 539 531 540 @unittest.skip("Commit queue testing temporarily disabled.")541 532 def test_land_failure(self): 542 533 commit_queue = MockCommitQueue([ -
trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py
r147709 r147826 29 29 import os 30 30 import StringIO 31 import unittest32 31 33 32 from webkitpy.common.checkout.scm import CheckoutNeedsUpdate … … 234 233 return test_results.TestResult(testname, [test_failures.FailureTextMismatch()]) 235 234 236 @unittest.skip("Commit queue testing temporarily disabled.")237 235 def test_commit_queue(self): 238 236 tool = MockTool() … … 318 316 self.assert_queue_outputs(queue, expected_logs=expected_logs) 319 317 320 @unittest.skip("Commit queue testing temporarily disabled.")321 318 def test_rollout(self): 322 319 tool = MockTool() … … 390 387 self.assertFalse(options.test) 391 388 392 @unittest.skip("Commit queue testing temporarily disabled.")393 389 def test_manual_reject_during_processing(self): 394 390 queue = SecondThoughtsCommitQueue(MockTool())
Note: See TracChangeset
for help on using the changeset viewer.