Changeset 147867 in webkit


Ignore:
Timestamp:
Apr 7, 2013 9:42:28 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Source/WebCore: [EFL] --minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
​https://bugs.webkit.org/show_bug.cgi?id=114089

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.

Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):

  • editing/FrameSelection.h:

(WebCore):

Tools: [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
​https://bugs.webkit.org/show_bug.cgi?id=114089

Patch by Ed Bartosh <​bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.

Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)

  • DumpRenderTree/AccessibilityController.cpp:
  • DumpRenderTree/AccessibilityUIElement.cpp:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::DumpRenderTreeChrome):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r147864 r147867  
     12013-04-07  Ed Bartosh  <bartosh@gmail.com>
     2
     3        [EFL] --minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
     4        https://bugs.webkit.org/show_bug.cgi?id=114089
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
     9        * editing/FrameSelection.cpp:
     10        (WebCore::FrameSelection::setSelection):
     11        * editing/FrameSelection.h:
     12        (WebCore):
     13
    1142013-04-06  Benjamin Poulain  <benjamin@webkit.org>
    215

  • trunk/Source/WebCore/editing/FrameSelection.cpp

    r147333 r147867  
    339339        revealSelection(alignment, RevealExtent);
    340340    }
    341 
     341#if HAVE(ACCESSIBILITY)
    342342    notifyAccessibilityForSelectionChange();
     343#endif
    343344    m_frame->document()->enqueueDocumentEvent(Event::create(eventNames().selectionchangeEvent, false, false));
    344345}

  • trunk/Source/WebCore/editing/FrameSelection.h

    r147721 r147867  
    279279
    280280    LayoutUnit lineDirectionPointForBlockDirectionNavigation(EPositionType);
    281    
     281
     282#if HAVE(ACCESSIBILITY)
    282283    void notifyAccessibilityForSelectionChange();
     284#endif
    283285
    284286    void focusedOrActiveStateChanged();
    … …  
    331333
    332334#if !(PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(EFL))
     335#if HAVE(ACCESSIBILITY)
    333336inline void FrameSelection::notifyAccessibilityForSelectionChange()
    334337{
    335338}
     339#endif
    336340#endif
    337341

  • trunk/Tools/ChangeLog

    r147866 r147867  
     12013-04-07  Ed Bartosh  <bartosh@gmail.com>
     2
     3        [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
     4        https://bugs.webkit.org/show_bug.cgi?id=114089
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
     9        * DumpRenderTree/AccessibilityController.cpp:
     10        * DumpRenderTree/AccessibilityUIElement.cpp:
     11        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
     12        (DumpRenderTreeChrome::DumpRenderTreeChrome):
     13        * DumpRenderTree/efl/DumpRenderTreeChrome.h:
     14        (DumpRenderTreeChrome):
     15
    1162013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
    217

  • trunk/Tools/DumpRenderTree/AccessibilityController.cpp

    r129308 r147867  
    2525
    2626#include "config.h"
     27
     28#if HAVE(ACCESSIBILITY)
     29
    2730#include "AccessibilityController.h"
    2831
    … …  
    163166    setLogAccessibilityEvents(false);
    164167}
     168#endif // HAVE(ACCESSIBILITY)

  • trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp

    r147854 r147867  
    2525
    2626#include "config.h"
     27
     28#if HAVE(ACCESSIBILITY)
     29
    2730#include "AccessibilityUIElement.h"
    2831
    … …  
    13471350    return accessibilityUIElementClass;
    13481351}
     1352#endif

  • trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

    r145849 r147867  
    7575    , m_evas(evas)
    7676    , m_gcController(adoptPtr(new GCController))
     77#if HAVE(ACCESSIBILITY)
    7778    , m_axController(adoptPtr(new AccessibilityController))
     79#endif
    7880{
    7981}
    … …  
    864866}
    865867
     868#if HAVE(ACCESSIBILITY)
    866869AccessibilityController* DumpRenderTreeChrome::accessibilityController() const
    867870{
    868871    return m_axController.get();
    869872}
     873#endif

  • trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.h

    r145014 r147867  
    6969    Evas_Object* createView() const;
    7070    bool initialize();
     71#if HAVE(ACCESSIBILITY)
    7172    AccessibilityController* accessibilityController() const;
    72 
     73    OwnPtr<AccessibilityController> m_axController;
     74#endif
    7375    Evas_Object* m_mainFrame;
    7476    Evas_Object* m_mainView;
    7577    Evas* m_evas;
    76     OwnPtr<AccessibilityController> m_axController;
    7778    OwnPtr<GCController> m_gcController;
    7879    Vector<Evas_Object*> m_extraViews;
Note: See TracChangeset for help on using the changeset viewer.