Changeset 147897 in webkit

Timestamp:

Apr 8, 2013 12:25:12 AM (11 years ago)

Author:

ryuan.choi@samsung.com

Message:

[EFL] rendering was broken when scrolled ewk_view_single
​https://bugs.webkit.org/show_bug.cgi?id=114135

Patch by Ryuan Choi <​ryuan.choi@samsung.com> on 2013-04-08
Reviewed by Gyuyoung Kim.

ewk_view_single use memcpy() to copy previous buffer for scrolling, but
memcpy() should not be used when source buffer and destination buffer are
overwrapped.

• ewk/ewk_view_single.cpp:

(_ewk_view_screen_move):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_view_single.cpp (modified) (2 diffs)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2013-04-08  Ryuan Choi  <ryuan.choi@samsung.com>
+
+        [EFL] rendering was broken when scrolled ewk_view_single
+        https://bugs.webkit.org/show_bug.cgi?id=114135
+
+        Reviewed by Gyuyoung Kim.
+
+        ewk_view_single use memcpy() to copy previous buffer for scrolling, but
+        memcpy() should not be used when source buffer and destination buffer are
+        overwrapped.
+
+        * ewk/ewk_view_single.cpp:
+        (_ewk_view_screen_move):
+
 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
 

trunk/Source/WebKit/efl/ewk/ewk_view_single.cpp

@@ -112 +112 @@
 
     uint32_t* source, * destination;
-    if (sourceX >= destinationX) {
+    if ((destinationX > sourceX && destinationX < sourceX + copyWidth)
+        || (destinationX < sourceX && destinationX + copyWidth > sourceX)) {
         for (size_t i = 0; i < copyHeight; i++) {
             source = sourceBegin + (imageWidth * startHeight);
             destination = destinationBegin + (imageWidth * startHeight);
             startHeight = startHeight + moveLineUpDown;
-            memcpy(destination, source, copyLength);
+            memmove(destination, source, copyLength);
         }
     } else {
@@ -124 +125 @@
             destination = destinationBegin + (imageWidth * startHeight);
             startHeight = startHeight + moveLineUpDown;
-            memmove(destination, source, copyLength);
+            memcpy(destination, source, copyLength);
         }
     }