Changeset 147916 in webkit


Ignore:
Timestamp:
Apr 8, 2013 9:05:52 AM (11 years ago)
Author:
sergio@webkit.org
Message:

[GTK] Toggle OverWrite mode when pressing the Insert key
https://bugs.webkit.org/show_bug.cgi?id=113384

Reviewed by Martin Robinson.

Perform an OverWrite command as a response to the emission of the
toggle-overwrite signal. Due to the nature of the command it will
only do that when being on a richly editable web content.

  • platform/gtk/KeyBindingTranslator.cpp:

(WebCore::toggleOverwriteCallback):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r147915 r147916  
     12013-04-08  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [GTK] Toggle OverWrite mode when pressing the Insert key
     4        https://bugs.webkit.org/show_bug.cgi?id=113384
     5
     6        Reviewed by Martin Robinson.
     7
     8        Perform an OverWrite command as a response to the emission of the
     9        toggle-overwrite signal. Due to the nature of the command it will
     10        only do that when being on a richly editable web content.
     11
     12        * platform/gtk/KeyBindingTranslator.cpp:
     13        (WebCore::toggleOverwriteCallback):
     14
    1152013-04-08  Seokju Kwon  <seokju.kwon@gmail.com>
    216
  • trunk/Source/WebCore/platform/gtk/KeyBindingTranslator.cpp

    r143696 r147916  
    5858}
    5959
    60 static void toggleOverwriteCallback(GtkWidget* widget, KeyBindingTranslator*)
    61 {
    62     // We don't support toggling the overwrite mode, but the default callback expects
    63     // the GtkTextView to have a layout, so we handle this signal just to stop it.
     60static void toggleOverwriteCallback(GtkWidget* widget, KeyBindingTranslator* translator)
     61{
    6462    g_signal_stop_emission_by_name(widget, "toggle-overwrite");
     63    translator->addPendingEditorCommand("OverWrite");
    6564}
    6665
Note: See TracChangeset for help on using the changeset viewer.