Changeset 147972 in webkit

Timestamp:

Apr 8, 2013 6:27:49 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] MathExtras: macros defined in math.h conflict with the real functions
​https://bugs.webkit.org/show_bug.cgi?id=112683

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.

After calls to signbit and friends were prefixed with std:: in
r143232, the BlackBerry port no longer compiles.

The solution is to get rid of the macros defined in math.h and use
the real functions instead.

• wtf/MathExtras.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/MathExtras.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-04-08  Alberto Garcia  <agarcia@igalia.com>
+
+        [BlackBerry] MathExtras: macros defined in math.h conflict with the real functions
+        https://bugs.webkit.org/show_bug.cgi?id=112683
+
+        Reviewed by Darin Adler.
+
+        After calls to signbit and friends were prefixed with std:: in
+        r143232, the BlackBerry port no longer compiles.
+
+        The solution is to get rid of the macros defined in math.h and use
+        the real functions instead.
+
+        * wtf/MathExtras.h:
+
 2013-04-08  Max Vujovic  <mvujovic@adobe.com>
 

trunk/Source/WTF/wtf/MathExtras.h

@@ -49 +49 @@
 // into the standard namespace.
 #include <math.h>
+// These macros from math.h conflict with the real functions in the std namespace.
+#undef signbit
+#undef isnan
+#undef isinf
+#undef isfinite
 #endif