Changeset 148081 in webkit

Timestamp:

Apr 10, 2013 12:36:42 AM (11 years ago)

Author:

zandobersek@gmail.com

Message:

REGRESSION (r147719): Failures in two a11y tests on GTK
​https://bugs.webkit.org/show_bug.cgi?id=114259

Reviewed by Ryosuke Niwa.

No new tests - covered by existing tests.

Partially revert r147719, restoring the possible creation of the AXObject cache
and the subsequent call to its handleFocusedUIElementChanged method. Removing this
code caused regressions in accessibility tests on the GTK port, so the comment about
the AXObject cache is adjusted accordingly.

• dom/Document.cpp:

(WebCore::Document::setFocusedNode):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
+
+        REGRESSION (r147719): Failures in two a11y tests on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=114259
+
+        Reviewed by Ryosuke Niwa.
+
+        No new tests - covered by existing tests.
+
+        Partially revert r147719, restoring the possible creation of the AXObject cache 
+        and the subsequent call to its handleFocusedUIElementChanged method. Removing this
+        code caused regressions in accessibility tests on the GTK port, so the comment about
+        the AXObject cache is adjusted accordingly.
+
+        * dom/Document.cpp:
+        (WebCore::Document::setFocusedNode):
+
 2013-04-09  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -3489 +3489 @@
     }
 
+    if (!focusChangeBlocked && m_focusedNode) {
+        // Create the AXObject cache in a focus change because GTK relies on it.
+        if (AXObjectCache* cache = axObjectCache())
+            cache->handleFocusedUIElementChanged(oldFocusedNode.get(), newFocusedNode.get());
+    }
+
     if (!focusChangeBlocked)
         page()->chrome()->focusedNodeChanged(m_focusedNode.get());