Changeset 148094 in webkit

Timestamp:

Apr 10, 2013 7:58:37 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[Texmap] Update a dirty region which is not covered with keepRect.
​https://bugs.webkit.org/show_bug.cgi?id=113752

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.

There can be a dirty region which is not covered with keepRect.
However the dirty could be inside the tile area. In this case,
currently we ignore the dirty by intersecting with keepRect
and the dirty region will not be invalidated until the tile is
recreated. We must expand the keep rect to its intersecting tiles
to make sure that the dirty region is applied to existing tiles.

No tests needed, change is unobservable.

• platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::invalidate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/TiledBackingStore.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-10  JungJik Lee  <jungjik.lee@samsung.com>
+
+        [Texmap] Update a dirty region which is not covered with keepRect.
+        https://bugs.webkit.org/show_bug.cgi?id=113752
+
+        Reviewed by Jocelyn Turcotte.
+
+        There can be a dirty region which is not covered with keepRect. 
+        However the dirty could be inside the tile area. In this case, 
+        currently we ignore the dirty by intersecting with keepRect 
+        and the dirty region will not be invalidated until the tile is 
+        recreated. We must expand the keep rect to its intersecting tiles 
+        to make sure that the dirty region is applied to existing tiles. 
+
+        No tests needed, change is unobservable.
+
+        * platform/graphics/TiledBackingStore.cpp:
+        (WebCore::TiledBackingStore::invalidate):
+
 2013-04-10  Laszlo Gombos  <l.gombos@samsung.com>
 

trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp

@@ -82 +82 @@
 {
     IntRect dirtyRect(mapFromContents(contentsDirtyRect));
+    IntRect keepRectFitToTileSize = tileRectForCoordinate(tileCoordinateForPoint(m_keepRect.location()));
+    keepRectFitToTileSize.unite(tileRectForCoordinate(tileCoordinateForPoint(innerBottomRight(m_keepRect))));
 
     // Only iterate on the part of the rect that we know we might have tiles.
-    IntRect coveredDirtyRect = intersection(dirtyRect, m_keepRect);
+    IntRect coveredDirtyRect = intersection(dirtyRect, keepRectFitToTileSize);
     Tile::Coordinate topLeft = tileCoordinateForPoint(coveredDirtyRect.location());
     Tile::Coordinate bottomRight = tileCoordinateForPoint(innerBottomRight(coveredDirtyRect));