Changeset 14810 in webkit

Timestamp:

Jun 10, 2006 9:07:11 PM (18 years ago)

Author:

ddkilzer

Message:

LayoutTests:

Patch by mitzpettel. Reviewed by hyatt.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9334 Incomplete repaint when changing block from non-positioned to positioned

• fast/repaint/static-to-positioned-expected.checksum: Added.
• fast/repaint/static-to-positioned-expected.png: Added.
• fast/repaint/static-to-positioned-expected.txt: Added.
• fast/repaint/static-to-positioned.html: Added.

WebCore:

Patch by mitzpettel. Reviewed by hyatt.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9334 Incomplete repaint when changing block from non-positioned to positioned

Test: fast/repaint/static-to-positioned.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): If changing from static to positioned, repaint as static.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/static-to-positioned-expected.checksum (added)
• LayoutTests/fast/repaint/static-to-positioned-expected.png (added)
• LayoutTests/fast/repaint/static-to-positioned-expected.txt (added)
• LayoutTests/fast/repaint/static-to-positioned.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2006-06-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>
+
+        Reviewed by hyatt.
+
+        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9334
+          Incomplete repaint when changing block from non-positioned to positioned
+
+        * fast/repaint/static-to-positioned-expected.checksum: Added.
+        * fast/repaint/static-to-positioned-expected.png: Added.
+        * fast/repaint/static-to-positioned-expected.txt: Added.
+        * fast/repaint/static-to-positioned.html: Added.
+
 2006-06-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-06-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>
+
+        Reviewed by hyatt.
+
+        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9334
+          Incomplete repaint when changing block from non-positioned to positioned
+
+        Test: fast/repaint/static-to-positioned.html
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::setStyle): If changing from static to positioned, repaint
+        as static.
+
 2006-06-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>
 

trunk/WebCore/rendering/RenderObject.cpp

@@ -2060 +2060 @@
         if (d == RenderStyle::Layout && m_parent && m_style->position() != style->position()) {
             markContainingBlocksForLayout();
+            if (m_style->position() == StaticPosition)
+                repaint();
             if (isRenderBlock()) {
                 if (style->position() == StaticPosition) {