Changeset 148118 in webkit

Timestamp:

Apr 10, 2013 11:50:15 AM (11 years ago)

Author:

Patrick Gansterer

Message:

Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute
​https://bugs.webkit.org/show_bug.cgi?id=114352

Reviewed by Timothy Hatcher.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

• page/Console.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Console.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-10  Patrick Gansterer  <paroga@webkit.org>
+
+        Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute
+        https://bugs.webkit.org/show_bug.cgi?id=114352
+
+        Reviewed by Timothy Hatcher.
+
+        The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
+
+        * page/Console.idl:
+
 2013-04-10  Alexandru Chiculita  <achicu@adobe.com>
 

trunk/Source/WebCore/page/Console.idl

@@ -45 +45 @@
     [CallWith=ScriptArguments] void markTimeline();
 
-#if defined(ENABLE_JAVASCRIPT_DEBUGGER) && ENABLE_JAVASCRIPT_DEBUGGER
     // As per spec: http://www.w3.org/TR/WebIDL/#idl-sequence
     // "Sequences must not be used as the type of an attribute, constant or exception field."
     // FIXME: this will lead to BUG console.profiles !== console.profiles as profile will always returns new array.
-    readonly attribute ScriptProfile[] profiles;
-    [Custom] void profile(in DOMString title);
-    [Custom] void profileEnd(in DOMString title);
-#endif
+    [Conditional=JAVASCRIPT_DEBUGGER] readonly attribute ScriptProfile[] profiles;
+    [Conditional=JAVASCRIPT_DEBUGGER, Custom] void profile(in DOMString title);
+    [Conditional=JAVASCRIPT_DEBUGGER, Custom] void profileEnd(in DOMString title);
 
     void time(in [TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString title);