Changeset 148128 in webkit

Timestamp:

Apr 10, 2013 12:38:07 PM (11 years ago)

Author:

akling@apple.com

Message:

Disallow programmatic movement of the browser window while user gestures are in progress.
<​http://webkit.org/b/114271>
<rdar://problem/13226530>

Reviewed by Oliver Hunt.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMWindow.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-10  Andreas Kling  <akling@apple.com>
+
+        Disallow programmatic movement of the browser window while user gestures are in progress.
+        <http://webkit.org/b/114271>
+        <rdar://problem/13226530>
+
+        Reviewed by Oliver Hunt.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::moveBy):
+        (WebCore::DOMWindow::moveTo):
+        (WebCore::DOMWindow::resizeBy):
+        (WebCore::DOMWindow::resizeTo):
+
 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -1449 +1449 @@
 void DOMWindow::moveBy(float x, float y) const
 {
+    if (UserGestureIndicator::processingUserGesture())
+        return;
+
     if (!m_frame)
         return;
@@ -1468 +1471 @@
 void DOMWindow::moveTo(float x, float y) const
 {
+    if (UserGestureIndicator::processingUserGesture())
+        return;
+
     if (!m_frame)
         return;
@@ -1489 +1495 @@
 void DOMWindow::resizeBy(float x, float y) const
 {
+    if (UserGestureIndicator::processingUserGesture())
+        return;
+
     if (!m_frame)
         return;
@@ -1507 +1516 @@
 void DOMWindow::resizeTo(float width, float height) const
 {
+    if (UserGestureIndicator::processingUserGesture())
+        return;
+
     if (!m_frame)
         return;