Changeset 148131 in webkit


Ignore:
Timestamp:
Apr 10, 2013 1:02:43 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Clicking on the volume slider of HTML5 elements is pausing sometimes
​https://bugs.webkit.org/show_bug.cgi?id=112548

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-04-10
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/click-volume-bar-not-pausing.html

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Calling the setDefaultHandled() method on the event prevents it
from being incorrectly propagated from the volume button up to the
MediaDocument.

LayoutTests:

Added test.

  • media/click-volume-bar-not-pausing-expected.txt: Added.
  • media/click-volume-bar-not-pausing.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r148130 r148131  
     12013-04-10  Xabier Rodriguez Calvar  <calvaris@igalia.com>
     2
     3        Clicking on the volume slider of HTML5 elements is pausing sometimes
     4        https://bugs.webkit.org/show_bug.cgi?id=112548
     5
     6        Reviewed by Eric Carlson.
     7
     8        Added test.
     9
     10        * media/click-volume-bar-not-pausing-expected.txt: Added.
     11        * media/click-volume-bar-not-pausing.html: Added.
     12
    1132013-04-10  Michael Saboff  <msaboff@apple.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r148129 r148131  
     12013-04-10  Xabier Rodriguez Calvar  <calvaris@igalia.com>
     2
     3        Clicking on the volume slider of HTML5 elements is pausing sometimes
     4        https://bugs.webkit.org/show_bug.cgi?id=112548
     5
     6        Reviewed by Eric Carlson.
     7
     8        Test: media/click-volume-bar-not-pausing.html
     9
     10        * html/shadow/MediaControlElementTypes.cpp:
     11        (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
     12        Calling the setDefaultHandled() method on the event prevents it
     13        from being incorrectly propagated from the volume button up to the
     14        MediaDocument.
     15
    1162013-04-10  Arvid Nilsson  <anilsson@rim.com>
    217

  • trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp

    r148099 r148131  
    273273    if (m_clearMutedOnUserInteraction)
    274274        mediaController()->setMuted(false);
     275    event->setDefaultHandled();
    275276}
    276277
Note: See TracChangeset for help on using the changeset viewer.