Changeset 148169 in webkit

Timestamp:

Apr 10, 2013 8:23:26 PM (11 years ago)

Author:

gyuyoung.kim@samsung.com

Message:

[WK2] Build warning in didReceiveMessage() generated by messages.py
​https://bugs.webkit.org/show_bug.cgi?id=112513

Reviewed by Anders Carlsson.

Legacy receiver makes -Wunused-parameter build warnings. This patch is to fix them.

• Scripts/webkit2/messages.py:

(generate_message_handler):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkit2/messages.py (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-04-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        [WK2] Build warning in didReceiveMessage() generated by messages.py
+        https://bugs.webkit.org/show_bug.cgi?id=112513
+
+        Reviewed by Anders Carlsson.
+
+        Legacy receiver makes -Wunused-parameter build warnings. This patch is to fix them.
+
+        * Scripts/webkit2/messages.py:
+        (generate_message_handler):
+
 2013-04-10  Jaehun Lim  <ljaehun.lim@samsung.com>
 

trunk/Source/WebKit2/Scripts/webkit2/messages.py

@@ -567 +567 @@
         result.append('{\n')
         result += [async_message_statement(receiver, message) for message in async_messages]
+        if not receiver.has_attribute(LEGACY_RECEIVER_ATTRIBUTE):
+            result.append('    UNUSED_PARAM(connection);\n')
         result.append('    ASSERT_NOT_REACHED();\n')
         result.append('}\n')
@@ -578 +580 @@
         result.append('{\n')
         result += [sync_message_statement(receiver, message) for message in sync_messages]
+        if not receiver.has_attribute(LEGACY_RECEIVER_ATTRIBUTE):
+            result.append('    UNUSED_PARAM(connection);\n')
         result.append('    ASSERT_NOT_REACHED();\n')
         result.append('}\n')