Changeset 148173 in webkit

Timestamp:

Apr 10, 2013 11:04:31 PM (11 years ago)

Author:

glenn@skynav.com

Message:

[webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
​https://bugs.webkit.org/show_bug.cgi?id=114410

Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git.add_list): Remove optional return_exit_code argument. Remove return value.

• Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.add): Remove optional return_exit_code argument.
(SCM.add_list): Remove optional return_exit_code argument.

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.add_list): Remove optional return_exit_code argument. Remove return value.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/checkout/scm/git.py (modified) (1 diff)
• Scripts/webkitpy/common/checkout/scm/scm.py (modified) (1 diff)
• Scripts/webkitpy/common/checkout/scm/svn.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-04-10  Glenn Adams  <glenn@skynav.com>
+
+        [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
+        https://bugs.webkit.org/show_bug.cgi?id=114410
+
+        Reviewed by Ryosuke Niwa.
+
+        * Scripts/webkitpy/common/checkout/scm/git.py:
+        (Git.add_list): Remove optional return_exit_code argument. Remove return value.
+        * Scripts/webkitpy/common/checkout/scm/scm.py:
+        (SCM.add): Remove optional return_exit_code argument.
+        (SCM.add_list): Remove optional return_exit_code argument.
+        * Scripts/webkitpy/common/checkout/scm/svn.py:
+        (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
+
 2013-04-10  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py

@@ -163 +163 @@
         return '^(?P<status>[%s])\t(?P<filename>.+)$' % expected_types
 
-    def add_list(self, paths, return_exit_code=False):
-        return self._run_git(["add"] + paths, return_exit_code=return_exit_code)
+    def add_list(self, paths):
+        self._run_git(["add"] + paths)
 
     def delete_list(self, paths):

trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

@@ -131 +131 @@
         self._subclass_must_implement()
 
-    def add(self, path, return_exit_code=False):
-        self.add_list([path], return_exit_code)
-
-    def add_list(self, paths, return_exit_code=False):
+    def add(self, path):
+        self.add_list([path])
+
+    def add_list(self, paths):
         self._subclass_must_implement()
 

trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py

@@ -185 +185 @@
         for path in paths:
             self._add_parent_directories(os.path.dirname(os.path.abspath(path)))
-        return self._run_svn(["add"] + paths, return_exit_code=return_exit_code)
+        self._run_svn(["add"] + paths)
 
     def _delete_parent_directories(self, path):