Changeset 148210 in webkit

Timestamp:

Apr 11, 2013 9:38:32 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=76796

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-04-11
Reviewed by Chris Fleizach.

Source/WebCore:

When using caret-browsing with the right and left arrows, the
behaviour of menuLists should be the same as listBoxes. This means
not default-handling the event and passing it up the stack instead.

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):

Tools:

Make the Gtk window for the DRT a toplevel so that it gets the
focus from the window manager when the test starts.

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(main):

LayoutTests:

Adding a new test to verify that it is possible to arrow out of
combo boxes when caret browsing is enabled. Updated failing tests
to reflect changed accessibility events in the DRT.

• platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated.
• platform/gtk/accessibility/caret-browsing-select-focus-expected.txt: Added.
• platform/gtk/accessibility/caret-browsing-select-focus.html: Added.
• platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Updated.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt (modified) (1 diff)
• LayoutTests/platform/gtk/accessibility/caret-browsing-select-focus-expected.txt (added)
• LayoutTests/platform/gtk/accessibility/caret-browsing-select-focus.html (added)
• LayoutTests/platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLSelectElement.cpp (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-04-11  Brian Holt  <brian.holt@samsung.com>
+
+        [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
+        https://bugs.webkit.org/show_bug.cgi?id=76796
+
+        Reviewed by Chris Fleizach.
+
+        Adding a new test to verify that it is possible to arrow out of
+        combo boxes when caret browsing is enabled. Updated failing tests
+        to reflect changed accessibility events in the DRT.
+
+        * platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated.
+        * platform/gtk/accessibility/caret-browsing-select-focus-expected.txt: Added.
+        * platform/gtk/accessibility/caret-browsing-select-focus.html: Added.
+        * platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Updated.
+
 2013-04-11  Dirk Schulze  <krit@webkit.org>
 

trunk/LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt

@@ -1 @@
-Accessibility object emitted "focus-event = 1" / Name: "(No name)" / Role: 50
-Accessibility object emitted "state-change:focused = 1" / Name: "(No name)" / Role: 50
 Accessibility object emitted "state-change:busy = 0" / Name: "(No name)" / Role: 80
 Accessibility object emitted "property-change:accessible-value" / Name: "(No name)" / Role: 50

trunk/LayoutTests/platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt

@@ -1 @@
-Accessibility object emitted "focus-event = 1" / Name: "foo" / Role: 11
-Accessibility object emitted "state-change:focused = 1" / Name: "foo" / Role: 11
 Accessibility object emitted "focus-event = 1" / Name: "bar" / Role: 11
 Accessibility object emitted "state-change:focused = 1" / Name: "bar" / Role: 11

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-11  Brian Holt  <brian.holt@samsung.com>
+
+        [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
+        https://bugs.webkit.org/show_bug.cgi?id=76796
+
+        Reviewed by Chris Fleizach.
+
+        When using caret-browsing with the right and left arrows, the
+        behaviour of menuLists should be the same as listBoxes. This means
+        not default-handling the event and passing it up the stack instead.
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
+
 2013-04-11  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/html/HTMLSelectElement.cpp

@@ -53 +53 @@
 #include "RenderTheme.h"
 #include "ScriptEventListener.h"
+#include "Settings.h"
 #include "SpatialNavigation.h"
 #include <wtf/text/StringBuilder.h>
@@ -1121 +1122 @@
         const Vector<HTMLElement*>& listItems = this->listItems();
         int listIndex = optionToListIndex(selectedIndex());
+
+        // When using caret browsing, we want to be able to move the focus
+        // out of the select element when user hits a left or right arrow key.
+        const Frame* frame = document()->frame();
+        if (frame && frame->settings() && frame->settings()->caretBrowsingEnabled()) {
+            if (keyIdentifier == "Left" || keyIdentifier == "Right")
+                return;
+        }
 
         if (keyIdentifier == "Down" || keyIdentifier == "Right")

trunk/Tools/ChangeLog

@@ +1 @@
+2013-04-11  Brian Holt  <brian.holt@samsung.com>
+
+        [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
+        https://bugs.webkit.org/show_bug.cgi?id=76796
+
+        Reviewed by Chris Fleizach.
+
+        Make the Gtk window for the DRT a toplevel so that it gets the
+        focus from the window manager when the test starts.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (main):
+
 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 

trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

@@ -1485 +1485 @@
     initializeFonts();
 
-    window = gtk_window_new(GTK_WINDOW_POPUP);
+    window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
 #ifdef GTK_API_VERSION_2
     container = gtk_hbox_new(TRUE, 0);